Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2182423002: [DevTools] Remove V8ContentSearchUtil. (Closed)

Created:
4 years, 4 months ago by dgozman
Modified:
4 years, 4 months ago
Reviewers:
kozy, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@strings-1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove V8ContentSearchUtil. BUG=580337 TBR=pfeldman Committed: https://crrev.com/42ab3ad19bbbc798996b3226f8b1be692debae6d Cr-Commit-Position: refs/heads/master@{#408567}

Patch Set 1 #

Patch Set 2 : query ensure16bit #

Patch Set 3 : query ensure16bit #

Total comments: 2

Patch Set 4 : const bool #

Patch Set 5 : just removal #

Messages

Total messages: 26 (15 generated)
dgozman
Take a look please.
4 years, 4 months ago (2016-07-27 01:10:14 UTC) #2
kozy
lgtm https://codereview.chromium.org/2182423002/diff/40001/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h File third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h (right): https://codereview.chromium.org/2182423002/diff/40001/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h#newcode67 third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h:67: std::unique_ptr<protocol::Array<protocol::Debugger::API::SearchMatch>> searchInTextByLines(const uint16_t* text, size_t textLength, const uint16_t* ...
4 years, 4 months ago (2016-07-27 01:17:05 UTC) #3
dgozman
https://codereview.chromium.org/2182423002/diff/40001/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h File third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h (right): https://codereview.chromium.org/2182423002/diff/40001/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h#newcode67 third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h:67: std::unique_ptr<protocol::Array<protocol::Debugger::API::SearchMatch>> searchInTextByLines(const uint16_t* text, size_t textLength, const uint16_t* query, ...
4 years, 4 months ago (2016-07-27 01:19:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182423002/60001
4 years, 4 months ago (2016-07-27 16:06:56 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/226154)
4 years, 4 months ago (2016-07-27 16:12:33 UTC) #11
dgozman
TBR'ing pfeldman@ for gypi.
4 years, 4 months ago (2016-07-27 16:26:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182423002/60001
4 years, 4 months ago (2016-07-27 16:26:56 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/228381)
4 years, 4 months ago (2016-07-27 16:37:14 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182423002/80001
4 years, 4 months ago (2016-07-29 01:42:42 UTC) #22
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-07-29 03:19:58 UTC) #24
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 03:24:24 UTC) #26
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/42ab3ad19bbbc798996b3226f8b1be692debae6d
Cr-Commit-Position: refs/heads/master@{#408567}

Powered by Google App Engine
This is Rietveld 408576698