In rietveld.filter_latest_jobs, handle jobs with no build number.

In rietveld.filter_latest_jobs, handle jobs with no build number.

Currently, in some circumstances, filter_try_jobs may throw an error depending on the state of the current try jobs.

This CL changes just this method so that it doesn't throw a KeyError if there are jobs with no build number passed in.

Committed: https://crrev.com/e5e73d3df3d7d0a42f28040ab0b6fe022c1179c5
Cr-Commit-Position: refs/heads/master@{#408874}

[qyearsley, 2016-07-27 22:24:08]

qyearsley@chromium.org changed reviewers:
+ wkorman@chromium.org

[qyearsley, 2016-07-27 22:24:09]

https://codereview.chromium.org/2182413004/diff/40001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/pylintrc (right):

https://codereview.chromium.org/2182413004/diff/40001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/pylintrc:193:
method-rgx=(([a-z_][a-z0-9_]{2,30})|(test_[a-z0-9_]{2,60}))$
Many test methods in unit tests have names much longer than 30 characters. I
think this is fine for test method names, since they're meant to be descriptive,
but not necessarily short and memorable.

[qyearsley, 2016-07-27 22:26:43]

Description was changed from

==========
In rietveld.filter_latest_jobs support builds with no number.
==========

to

==========
In rietveld.filter_latest_jobs, handle jobs with no build number.

Currently, in some circumstances, filter_try_jobs may throw an error depending
on the state of the current try jobs.

This CL changes just this method so that it doesn't throw a KeyError if there
are jobs with no build number passed in.
==========

[qyearsley, 2016-07-29 16:16:29]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 16:17:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 17:18:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 17:18:17]

Dry run: This issue passed the CQ dry run.

[wkorman, 2016-07-29 18:33:46]

lgtm

https://codereview.chromium.org/2182413004/diff/60001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/pylintrc (right):

https://codereview.chromium.org/2182413004/diff/60001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/pylintrc:193:
method-rgx=(([a-z_][a-z0-9_]{2,30})|(test_[a-z0-9_]{2,60}))$
Add this to the change description, or do in separate change? Were we really
failing lint on test methods this whole time? Just curious.

[qyearsley, 2016-07-29 18:44:35]

https://codereview.chromium.org/2182413004/diff/60001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/pylintrc (right):

https://codereview.chromium.org/2182413004/diff/60001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/pylintrc:193:
method-rgx=(([a-z_][a-z0-9_]{2,30})|(test_[a-z0-9_]{2,60}))$
On 2016/07/29 at 18:33:45, wkorman wrote:
> Add this to the change description, or do in separate change? Were we really
failing lint on test methods this whole time? Just curious.

Committing in a separate CL makes sense, since this change is kind of not
related to this CL. Made separate CL: http://crrev.com/2192213002.

I recently enabled a bunch of pylint checks, including name checks
(http://crrev.com/2120083002), so these test method names are now not passing
lint. But pylint only complains about lines that are changed in a CL, not all
lines in the whole project that don't pass lint.

[qyearsley, 2016-07-30 17:26:15]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-30 17:26:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 19:22:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-30 19:22:49]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-07-30 19:53:38]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2016-07-30 19:53:39]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2182413004/#ps80001
(title: "Removed pylintrc change")

[commit-bot: I haz the power, 2016-07-30 19:53:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 19:56:20]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-30 19:57:38]

Description was changed from

==========
In rietveld.filter_latest_jobs, handle jobs with no build number.

Currently, in some circumstances, filter_try_jobs may throw an error depending
on the state of the current try jobs.

This CL changes just this method so that it doesn't throw a KeyError if there
are jobs with no build number passed in.
==========

to

==========
In rietveld.filter_latest_jobs, handle jobs with no build number.

Currently, in some circumstances, filter_try_jobs may throw an error depending
on the state of the current try jobs.

This CL changes just this method so that it doesn't throw a KeyError if there
are jobs with no build number passed in.

Committed: https://crrev.com/e5e73d3df3d7d0a42f28040ab0b6fe022c1179c5
Cr-Commit-Position: refs/heads/master@{#408874}
==========

[commit-bot: I haz the power, 2016-07-30 19:57:39]

Patchset 5 (id:??) landed as
https://crrev.com/e5e73d3df3d7d0a42f28040ab0b6fe022c1179c5
Cr-Commit-Position: refs/heads/master@{#408874}