Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1076)

Issue 2182413003: remove "swdh_not_handled*" from chrome_crash_reporter_client_win.cc (Closed)

Created:
4 years, 4 months ago by horo
Modified:
4 years, 4 months ago
Reviewers:
ananta, sky
CC:
chromium-reviews, ananta, serviceworker-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

remove "swdh_not_handled*" from chrome_crash_reporter_client_win.cc BUG=625040 Committed: https://crrev.com/6e3b64faae9182ebc09e5c9f76357ad702fee7a0 Cr-Commit-Position: refs/heads/master@{#408293}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/app/chrome_crash_reporter_client_win.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
horo
sky@ Please review this.
4 years, 4 months ago (2016-07-27 06:46:59 UTC) #4
sky
I'm not familiar with this code. +ananta
4 years, 4 months ago (2016-07-27 15:24:40 UTC) #8
ananta
lgtm
4 years, 4 months ago (2016-07-27 21:01:47 UTC) #9
sky
Rubber stamp LGTM
4 years, 4 months ago (2016-07-27 21:57:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182413003/1
4 years, 4 months ago (2016-07-28 00:34:36 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 00:38:09 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 00:39:20 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e3b64faae9182ebc09e5c9f76357ad702fee7a0
Cr-Commit-Position: refs/heads/master@{#408293}

Powered by Google App Engine
This is Rietveld 408576698