DevTools: fix inspector/elements/css-rule-hover-highlights-selectors.html

DevTools: fix inspector/elements/css-rule-hover-highlights-selectors.html

The test should wait until overlay gets repainted.

BUG=563650
R=dgozman

Committed: https://crrev.com/7727d40169ab36a8e59a3d70ea0d05ae6aa3e807
Cr-Commit-Position: refs/heads/master@{#408283}

[lushnikov, 2016-07-27 00:36:53]

ptal!

[caseq, 2016-07-27 00:48:24]

caseq@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq, 2016-07-27 00:48:25]

https://codereview.chromium.org/2182373002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
(right):

https://codereview.chromium.org/2182373002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js:79:
InspectorTest.evaluateInPageAsync("requestAnimationFrame(%callback)", callback);
Rather than using rAF, you probably want testRunner.layoutAndPaintAsyncThen()

https://codereview.chromium.org/2182373002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js:86:
InspectorTest.evaluateInPageAsync = function(string, callback)
Please don't. See invokeInPageAsync:
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/http/test...

[lushnikov, 2016-07-27 03:14:46]

https://codereview.chromium.org/2182373002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
(right):

https://codereview.chromium.org/2182373002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js:79:
InspectorTest.evaluateInPageAsync("requestAnimationFrame(%callback)", callback);
On 2016/07/27 00:48:25, caseq wrote:
> Rather than using rAF, you probably want testRunner.layoutAndPaintAsyncThen()

I'm not sure if the layoutAndPaintAsyncThen will force raf; but afaiu rAF's are
synchronized inside the process (so requesting raf is good enough)

https://codereview.chromium.org/2182373002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js:86:
InspectorTest.evaluateInPageAsync = function(string, callback)
On 2016/07/27 00:48:25, caseq wrote:
> Please don't. See invokeInPageAsync:
>
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/http/test...

Beautiful. Thank you!

[caseq, 2016-07-27 18:31:54]

lgtm

[lushnikov, 2016-07-27 20:08:32]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-07-27 20:08:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 20:10:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 20:10:26]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[lushnikov, 2016-07-27 22:00:51]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-07-27 22:00:51]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2182373002/#ps60001
(title: "rebaseline")

[commit-bot: I haz the power, 2016-07-27 22:01:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 22:06:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 22:06:45]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lushnikov, 2016-07-27 23:02:16]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-07-27 23:02:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 00:03:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-28 00:07:25]

Description was changed from

==========
DevTools: fix inspector/elements/css-rule-hover-highlights-selectors.html

The test should wait until overlay gets repainted.

BUG=563650
R=dgozman
==========

to

==========
DevTools: fix inspector/elements/css-rule-hover-highlights-selectors.html

The test should wait until overlay gets repainted.

BUG=563650
R=dgozman

Committed: https://crrev.com/7727d40169ab36a8e59a3d70ea0d05ae6aa3e807
Cr-Commit-Position: refs/heads/master@{#408283}
==========

[commit-bot: I haz the power, 2016-07-28 00:07:26]

Patchset 4 (id:??) landed as
https://crrev.com/7727d40169ab36a8e59a3d70ea0d05ae6aa3e807
Cr-Commit-Position: refs/heads/master@{#408283}