Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2075)

Issue 2182333005: Audit and Deprecate DPI Functions in display::win (Closed)

Created:
4 years, 4 months ago by robliao
Modified:
4 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, robliao+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Audit and Deprecate DPI Functions in display::win SetDefaultDeviceScaleFactor is deprecated in favor of --force-device-scale-factor GetDPIScale and GetSystemMetricsInDIP are deprecated in favor of their equivalent per-HWND DPI aware replacements in ScreenWin. BUG=426656 Committed: https://crrev.com/34a04bf6f2c6969f4d038034b259adc6c08bae60 Cr-Commit-Position: refs/heads/master@{#408218}

Patch Set 1 #

Total comments: 2

Patch Set 2 : More Deprecation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M ui/display/win/dpi.h View 1 2 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
robliao
sky: Please review this CL. Thanks!
4 years, 4 months ago (2016-07-27 18:27:54 UTC) #3
sky
https://codereview.chromium.org/2182333005/diff/1/ui/display/win/dpi.h File ui/display/win/dpi.h (right): https://codereview.chromium.org/2182333005/diff/1/ui/display/win/dpi.h#newcode30 ui/display/win/dpi.h:30: // Deprecated. Use display::win::ScreenWin::GetSystemMetricsForHwnd instead. Should all of the ...
4 years, 4 months ago (2016-07-27 18:28:50 UTC) #5
robliao
https://codereview.chromium.org/2182333005/diff/1/ui/display/win/dpi.h File ui/display/win/dpi.h (right): https://codereview.chromium.org/2182333005/diff/1/ui/display/win/dpi.h#newcode30 ui/display/win/dpi.h:30: // Deprecated. Use display::win::ScreenWin::GetSystemMetricsForHwnd instead. On 2016/07/27 18:28:49, sky ...
4 years, 4 months ago (2016-07-27 18:42:56 UTC) #11
sky
Thanks, LGTM
4 years, 4 months ago (2016-07-27 19:12:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182333005/60001
4 years, 4 months ago (2016-07-27 19:51:10 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 4 months ago (2016-07-27 19:54:39 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 19:56:24 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/34a04bf6f2c6969f4d038034b259adc6c08bae60
Cr-Commit-Position: refs/heads/master@{#408218}

Powered by Google App Engine
This is Rietveld 408576698