|
|
DescriptionAudit and Deprecate DPI Functions in display::win
SetDefaultDeviceScaleFactor is deprecated in favor of --force-device-scale-factor
GetDPIScale and GetSystemMetricsInDIP are deprecated in favor of their equivalent per-HWND DPI aware replacements in ScreenWin.
BUG=426656
Committed: https://crrev.com/34a04bf6f2c6969f4d038034b259adc6c08bae60
Cr-Commit-Position: refs/heads/master@{#408218}
Patch Set 1 #
Total comments: 2
Patch Set 2 : More Deprecation #Messages
Total messages: 21 (14 generated)
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
robliao@chromium.org changed reviewers: + sky@chromium.org
sky: Please review this CL. Thanks!
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2182333005/diff/1/ui/display/win/dpi.h File ui/display/win/dpi.h (right): https://codereview.chromium.org/2182333005/diff/1/ui/display/win/dpi.h#newcode30 ui/display/win/dpi.h:30: // Deprecated. Use display::win::ScreenWin::GetSystemMetricsForHwnd instead. Should all of the functions in this file be deprecated?
Description was changed from ========== Add Deprecation Comment to display::win::GetSystemMetricsInDIP BUG=426656 ========== to ========== Add Deprecation Comment to display::win::GetDPIScale and display::win::GetSystemMetricsInDIP BUG=426656 ==========
Description was changed from ========== Add Deprecation Comment to display::win::GetDPIScale and display::win::GetSystemMetricsInDIP BUG=426656 ========== to ========== Audit and Deprecate DPI Functions in display::win SetDefaultDeviceScaleFactor is deprecated in favor of --force-device-scale-factor GetDPIScale and GetSystemMetricsInDIP are deprecated in favor of their equivalent per-HWND DPI aware replacements in ScreenWin. BUG=426656 ==========
Patchset #2 (id:20001) has been deleted
Patchset #2 (id:40001) has been deleted
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
https://codereview.chromium.org/2182333005/diff/1/ui/display/win/dpi.h File ui/display/win/dpi.h (right): https://codereview.chromium.org/2182333005/diff/1/ui/display/win/dpi.h#newcode30 ui/display/win/dpi.h:30: // Deprecated. Use display::win::ScreenWin::GetSystemMetricsForHwnd instead. On 2016/07/27 18:28:49, sky wrote: > Should all of the functions in this file be deprecated? Deprecated SetDefaultDeviceScaleFactor and GetDPIScale. The other ones are okay with per-monitor DPI.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks, LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robliao@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Audit and Deprecate DPI Functions in display::win SetDefaultDeviceScaleFactor is deprecated in favor of --force-device-scale-factor GetDPIScale and GetSystemMetricsInDIP are deprecated in favor of their equivalent per-HWND DPI aware replacements in ScreenWin. BUG=426656 ========== to ========== Audit and Deprecate DPI Functions in display::win SetDefaultDeviceScaleFactor is deprecated in favor of --force-device-scale-factor GetDPIScale and GetSystemMetricsInDIP are deprecated in favor of their equivalent per-HWND DPI aware replacements in ScreenWin. BUG=426656 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Audit and Deprecate DPI Functions in display::win SetDefaultDeviceScaleFactor is deprecated in favor of --force-device-scale-factor GetDPIScale and GetSystemMetricsInDIP are deprecated in favor of their equivalent per-HWND DPI aware replacements in ScreenWin. BUG=426656 ========== to ========== Audit and Deprecate DPI Functions in display::win SetDefaultDeviceScaleFactor is deprecated in favor of --force-device-scale-factor GetDPIScale and GetSystemMetricsInDIP are deprecated in favor of their equivalent per-HWND DPI aware replacements in ScreenWin. BUG=426656 Committed: https://crrev.com/34a04bf6f2c6969f4d038034b259adc6c08bae60 Cr-Commit-Position: refs/heads/master@{#408218} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/34a04bf6f2c6969f4d038034b259adc6c08bae60 Cr-Commit-Position: refs/heads/master@{#408218} |