Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2182333003: Revert of Sample 1% url whitelisted PPAPI downloads to ping safe browsing server (Closed)

Created:
4 years, 4 months ago by Jialiu Lin
Modified:
4 years, 4 months ago
Reviewers:
asanka, Lei Zhang
CC:
chromium-reviews, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Sample 1% url whitelisted PPAPI downloads to ping safe browsing server (patchset #7 id:140001 of https://codereview.chromium.org/2146703002/ ) Reason for revert: high crashing rate on canary https://crbug.com/630778 Original issue's description: > Sample 1% url whitelisted PPAPI downloads to ping SB server > > Similar to regular downloads, we want SB pings for requestors whose > URLs match the SB whitelist in flash downloads. To achieve that, we > sample 1% of whitelisted PPAPI downloads based on the > SafeBrowsingService::whitelist_sample_rate() if the user is in > extended reporting group and not in incognito mode. > > Also refactored download_protection_service_unittest to elliminate > the use of MessageLoop (deprecated). > > BUG=610924 > > Committed: https://crrev.com/96f81d5c22a83e5ea061484c7390f37e41816f31 > Cr-Commit-Position: refs/heads/master@{#406101} TBR=asanka@chromium.org,thestig@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=610924 Committed: https://crrev.com/91cc320065aa4178827809fc158b3249211c9565 Cr-Commit-Position: refs/heads/master@{#408163}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+610 lines, -784 lines) Patch
M chrome/browser/file_select_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/download_protection_service.h View 3 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/safe_browsing/download_protection_service.cc View 10 chunks +28 lines, -60 lines 0 comments Download
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 40 chunks +581 lines, -719 lines 0 comments Download
M chrome/test/ppapi/ppapi_filechooser_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Jialiu Lin
Created Revert of Sample 1% url whitelisted PPAPI downloads to ping safe browsing server
4 years, 4 months ago (2016-07-27 16:34:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182333003/1
4 years, 4 months ago (2016-07-27 16:34:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 17:18:26 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 17:19:47 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91cc320065aa4178827809fc158b3249211c9565
Cr-Commit-Position: refs/heads/master@{#408163}

Powered by Google App Engine
This is Rietveld 408576698