Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5065)

Unified Diff: chrome/android/webapk/libs/runtime_library/javatests/src/org/chromium/webapk/lib/runtime_library/WebApkServiceImplTest.java

Issue 2182303002: Merging under test java into instrumentation test java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@runtimelibrary
Patch Set: reenabling tests that this fixes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/chrome_public_apk_tmpl.gni ('k') | testing/android/proguard_for_test.flags » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/webapk/libs/runtime_library/javatests/src/org/chromium/webapk/lib/runtime_library/WebApkServiceImplTest.java
diff --git a/chrome/android/webapk/libs/runtime_library/javatests/src/org/chromium/webapk/lib/runtime_library/WebApkServiceImplTest.java b/chrome/android/webapk/libs/runtime_library/javatests/src/org/chromium/webapk/lib/runtime_library/WebApkServiceImplTest.java
index 916c9b227766eee902b10ea05a7f5a76addfdf56..110a931ef132394d12fd8213cd640fe66ba843a7 100644
--- a/chrome/android/webapk/libs/runtime_library/javatests/src/org/chromium/webapk/lib/runtime_library/WebApkServiceImplTest.java
+++ b/chrome/android/webapk/libs/runtime_library/javatests/src/org/chromium/webapk/lib/runtime_library/WebApkServiceImplTest.java
@@ -12,8 +12,8 @@ import android.content.pm.ApplicationInfo;
import android.content.pm.PackageManager;
import android.os.IBinder;
import android.test.InstrumentationTestCase;
+import android.test.suitebuilder.annotation.SmallTest;
-import org.chromium.base.test.util.DisabledTest;
import org.chromium.chrome.test.webapk.TestWebApkServiceImplWrapper;
import org.chromium.content.browser.test.util.CallbackHelper;
@@ -62,11 +62,8 @@ public class WebApkServiceImplTest extends InstrumentationTestCase {
/**
* Test that an application which is not allowed to use the WebAPK service actually cannot.
- *
- * @SmallTest
- * crbug.com/634390
*/
- @DisabledTest
+ @SmallTest
public void testApiFailsIfNoPermission() throws Exception {
IWebApkApi api = bindService(mContext, mTargetUid + 1, SMALL_ICON_ID);
try {
@@ -79,11 +76,8 @@ public class WebApkServiceImplTest extends InstrumentationTestCase {
/**
* Test that an application which is allowed to use the WebAPK service actually can.
- *
- * @SmallTest
- * crbug.com/634390
*/
- @DisabledTest
+ @SmallTest
public void testApiWorksIfHasPermission() throws Exception {
IWebApkApi api = bindService(mContext, mTargetUid, SMALL_ICON_ID);
try {
« no previous file with comments | « chrome/android/chrome_public_apk_tmpl.gni ('k') | testing/android/proguard_for_test.flags » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698