base/android/base_proguard_config.flags - Issue 2182303002: Merging under test java into instrumentation test java.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/android/base_proguard_config.flags

Issue 2182303002: Merging under test java into instrumentation test java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@runtimelibrary

Patch Set: Addressing agrieve's comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « BUILD.gn ('k') | build/android/gyp/util/proguard_util.py » ('j') | build/android/gyp/util/proguard_util.py » ('J')

OLD	NEW
1 # Keep line number information, useful for stack traces.	1 # Keep line number information, useful for stack traces.

2 -keepattributes SourceFile,LineNumberTable	2 -keepattributes SourceFile,LineNumberTable

3	3

4 # Keep all runtime visible annotations	4 # Keep all annotation related attributes that can affect runtime

5 -keepattributes RuntimeVisibleAnnotations	5 -keepattributes RuntimeVisible*Annotations

	6 -keepattributes AnnotationDefault

6	7

7 # Keep the annotations, because if we don't, the ProGuard rules that use them	8 # Keep the annotations, because if we don't, the ProGuard rules that use them

8 # will not be respected. These classes then show up in our final dex, which we	9 # will not be respected. These classes then show up in our final dex, which we

9 # do not want - see crbug.com/628226.	10 # do not want - see crbug.com/628226.

10 -keep @interface org.chromium.base.annotations.AccessedByNative	11 -keep @interface org.chromium.base.annotations.AccessedByNative

11 -keep @interface org.chromium.base.annotations.CalledByNative	12 -keep @interface org.chromium.base.annotations.CalledByNative

12 -keep @interface org.chromium.base.annotations.CalledByNativeUnchecked	13 -keep @interface org.chromium.base.annotations.CalledByNativeUnchecked

13 -keep @interface org.chromium.base.annotations.RemovableInRelease	14 -keep @interface org.chromium.base.annotations.RemovableInRelease

14 -keep @interface org.chromium.base.annotations.UsedByReflection	15 -keep @interface org.chromium.base.annotations.UsedByReflection

15	16

(...skipping 44 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
60 # ~1.1%, and reduces the method count by ~4.3%.	61 # ~1.1%, and reduces the method count by ~4.3%.

61 -allowaccessmodification	62 -allowaccessmodification

62	63

63 # Keep all enum values and valueOf methods. See	64 # Keep all enum values and valueOf methods. See

64 # http://proguard.sourceforge.net/index.html#manual/examples.html	65 # http://proguard.sourceforge.net/index.html#manual/examples.html

65 # for the reason for this. Also, see http://crbug.com/248037.	66 # for the reason for this. Also, see http://crbug.com/248037.

66 -keepclassmembers enum * {	67 -keepclassmembers enum * {

67 public static **[] values();	68 public static **[] values();

68 public static ** valueOf(java.lang.String);	69 public static ** valueOf(java.lang.String);

69 }	70 }

OLD	NEW