Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2182273003: FrameHostMsg_CreateChildFrame can legitimately fail during renderer shutdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index d799759d73354b4e16cd9613064cb4b017c14789..4e91ee36f7350f1734aeaa43abb4a52c4684a5a3 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -2808,11 +2808,11 @@ blink::WebFrame* RenderFrameImpl::createChildFrame(
Send(new FrameHostMsg_CreateChildFrame(params, &child_routing_id));
// Allocation of routing id failed, so we can't create a child frame. This can
- // happen if the synchronous IPC message above has failed.
- if (child_routing_id == MSG_ROUTING_NONE) {
- NOTREACHED() << "Failed to allocate routing id for child frame.";
+ // happen if the synchronous IPC message above has failed. This can
+ // legitimately happen when the browser process has already destroyed
+ // RenderProcessHost, but the renderer process hasn't quit yet.
+ if (child_routing_id == MSG_ROUTING_NONE)
return nullptr;
- }
// This method is always called by local frames, never remote frames.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698