[Devtools] Fix multi-line curl copy response when multi-part-form

[Devtools] Fix multi-line curl copy response when multi-part-form

This patch fixes a bug with windows where when a user would copy
command as curl from devtools network panel it would not copy properly
if data in the request had multiple lines.

BUG=505391
Committed: https://crrev.com/5a7bfc91402498a035371bbaa99765444732e75a
Cr-Commit-Position: refs/heads/master@{#409073}

[allada, 2016-07-27 18:08:08]

Patchset #1 (id:1) has been deleted

[allada, 2016-07-27 18:16:17]

Patchset #1 (id:20001) has been deleted

[allada, 2016-07-27 18:19:17]

allada@chromium.org changed reviewers:
+ lushnikov@chromium.org

[allada, 2016-07-27 18:19:18]

PTL

[lushnikov, 2016-07-27 20:16:18]

https://codereview.chromium.org/2182213006/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2182213006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:1367:
recognized by both cmd.exe and MS Crt arguments parser.
Can we update this comment?

https://codereview.chromium.org/2182213006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:1380: var
encapsChars = /[\r\n]/.test(str) ? "^\"" : "\"";
are you sure you want to have /[\r\n]/ and not /\r\n/?

[allada, 2016-07-27 22:28:00]

PTL

https://codereview.chromium.org/2182213006/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2182213006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:1367:
recognized by both cmd.exe and MS Crt arguments parser.
On 2016/07/27 20:16:18, lushnikov wrote:
> Can we update this comment?

Done.

https://codereview.chromium.org/2182213006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:1380: var
encapsChars = /[\r\n]/.test(str) ? "^\"" : "\"";
On 2016/07/27 20:16:18, lushnikov wrote:
> are you sure you want to have /[\r\n]/ and not /\r\n/?

This is simply checking to see if there are any new line characters; so any \r
or \n characters.

[lushnikov, 2016-07-30 00:34:54]

well, as far as it works.. lgtm

https://codereview.chromium.org/2182213006/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/platform/linux/inspector/curl-command-expected.txt
(left):

https://codereview.chromium.org/2182213006/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/platform/linux/inspector/curl-command-expected.txt:1:
Tests curl command generation
this file is removed, isn't it?..

[allada, 2016-08-01 19:01:03]

https://codereview.chromium.org/2182213006/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/platform/linux/inspector/curl-command-expected.txt
(left):

https://codereview.chromium.org/2182213006/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/platform/linux/inspector/curl-command-expected.txt:1:
Tests curl command generation
On 2016/07/30 00:34:54, lushnikov wrote:
> this file is removed, isn't it?..

Yes this file was removed because the test does not matter on the OS any more
and instead tells the generator which OS to generate the data using.

[allada, 2016-08-01 19:01:10]

The CQ bit was checked by allada@chromium.org

[commit-bot: I haz the power, 2016-08-01 19:01:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 22:33:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 22:33:13]

Failed to apply patch for
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:
While running git apply --index -3 -p1;
  error: patch failed:
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:1363
  Falling back to three-way merge...
  Applied patch to
'third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js' with
conflicts.
  U third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Patch:      
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
diff --git
a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
index
3e8c48459315aeac5e765d59755ca51643fb8c3e..9a71d18bfb0846da76b90a0182ebbaa27a4289af
100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
@@ -1363,24 +1363,39 @@ WebInspector.NetworkLogView.prototype = {
 
         function escapeStringWin(str)
         {
-            /* Replace quote by double quote (but not by \") because it is
-               recognized by both cmd.exe and MS Crt arguments parser.
+            /* If there are no new line characters do not escape the "
characters
+               since it only uglifies the command.
 
-               Replace % by "%" because it could be expanded to an environment
-               variable value. So %% becomes "%""%". Even if an env variable ""
-               (2 doublequotes) is declared, the cmd.exe will not
-               substitute it with its value.
+               Because cmd.exe parser and MS Crt arguments parsers use some of
the
+               same escape characters, they can interact with each other in
+               horrible ways, the order of operations is critical.
 
-               Replace each backslash with double backslash to make sure
-               MS Crt arguments parser won't collapse them.
+               Replace \ with \\ first because it is an escape character for
certain
+               conditions in both parsers.
 
-               Replace new line outside of quotes since cmd.exe doesn't let
-               to do it inside.
+               Replace all " with \" to ensure the first parser does not remove
it.
+
+               Then escape all characters we are not sure about with ^ to
ensure it
+               gets to MS Crt parser safely.
+
+               The % character is special because MS Crt parser will try and
look for
+               ENV variables and fill them in it's place. We cannot escape them
with %
+               and cannot escape them with ^ (because it's cmd.exe's escape not
MS Crt
+               parser); So we can get cmd.exe parser to escape the character
after it,
+               if it is followed by a valid beginning character of an ENV
variable.
+               This ensures we do not try and double escape another ^ if it was
placed
+               by the previous replace.
+
+               Lastly we replace new lines with ^ and TWO new lines because the
first
+               new line is there to enact the escape command the second is the
character
+               to escape (in this case new line).
             */
-            return "\"" + str.replace(/"/g, "\"\"")
-                             .replace(/%/g, "\"%\"")
-                             .replace(/\\/g, "\\\\")
-                             .replace(/[\r\n]+/g, "\"^$&\"") + "\"";
+            var encapsChars = /[\r\n]/.test(str) ? "^\"" : "\"";
+            return encapsChars + str.replace(/\\/g, "\\\\")
+                             .replace(/"/g, "\\\"")
+                             .replace(/[^a-zA-Z0-9\s_\-:=+~'\/.',?;()*`]/g,
"^$&")
+                             .replace(/%(?=[a-zA-Z0-9_])/g, "%^")
+                             .replace(/\r\n|[\n\r]/g, "^\n\n") + encapsChars;
         }
 
         function escapeStringPosix(str)

[commit-bot: I haz the power, 2016-08-01 22:38:55]

Description was changed from

==========
[Devtools] Fix multi-line curl copy response when multi-part-form

This patch fixes a bug with windows where when a user would copy
command as curl from devtools network panel it would not copy properly
if data in the request had multiple lines.

BUG=505391
==========

to

==========
[Devtools] Fix multi-line curl copy response when multi-part-form

This patch fixes a bug with windows where when a user would copy
command as curl from devtools network panel it would not copy properly
if data in the request had multiple lines.

BUG=505391

Committed: https://crrev.com/5a7bfc91402498a035371bbaa99765444732e75a
Cr-Commit-Position: refs/heads/master@{#409073}
==========

[commit-bot: I haz the power, 2016-08-01 22:38:56]

Patchset 2 (id:??) landed as
https://crrev.com/5a7bfc91402498a035371bbaa99765444732e75a
Cr-Commit-Position: refs/heads/master@{#409073}

[wOxxOm, 2016-10-25 01:38:28]

This patch wrongly escapes & inside doublequoted strings, see
https://crbug.com/658956