content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc - Issue 2182213004: Use ChildThreadImpl::thread_safe_sender in font proxy if available

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc

Issue 2182213004: Use ChildThreadImpl::thread_safe_sender in font proxy if available (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unittests Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/dwrite_font_proxy/dwrite_font_proxy_win.cc ('K') | « content/child/dwrite_font_proxy/dwrite_font_proxy_win.cc ('k') | content/child/dwrite_font_proxy/font_fallback_win_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc

diff --git a/content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc b/content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc

index 3e4bfc5ca7af2bdc70cc17db1dd9c3632ee75b15..8f3b51e3e71de321994edfaa1cf221a5e9b38099 100644

--- a/content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc

+++ b/content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc

@@ -48,7 +48,8 @@ class DWriteFontProxyUnitTest : public testing::Test {

fake_collection_ = new FakeFontCollection();

SetupFonts(fake_collection_.get());

mswr::MakeAndInitialize<DWriteFontCollectionProxy>(

- &collection_, factory.Get(), fake_collection_->GetTrackingSender());

+ &collection_, factory.Get(),

+ base::Bind(&FakeFontCollection::GetTrackingSender, fake_collection_));

}

~DWriteFontProxyUnitTest() override {

@@ -384,7 +385,8 @@ TEST_F(DWriteFontProxyUnitTest, TestCustomFontFiles) {

}

mswr::ComPtr<DWriteFontCollectionProxy> collection;

mswr::MakeAndInitialize<DWriteFontCollectionProxy>(

- &collection, factory.Get(), fonts->GetTrackingSender());

+ &collection, factory.Get(),

+ base::Bind(&FakeFontCollection::GetTrackingSender, fonts));

// Check that we can get the font family and match a font.

UINT32 index = UINT_MAX;