Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 2182213002: deploytool: Add README.md, migrate docs to it. (Closed)

Created:
4 years, 4 months ago by dnj
Modified:
4 years, 4 months ago
Reviewers:
estaab, iannucci
CC:
andrew.wang, chromium-reviews, infra-reviews+luci-go_chromium.org, M-A Ruel, tandrii+luci-go_chromium.org, todd
Base URL:
https://github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

deploytool: Add README.md, migrate docs to it. Update some minor deploytool behavior to conform to the documentation. Move deploytool into "cmd/deploytool" so a "go build" or "go install" will appropriately name it "deploytool" instead of "cmd". BUG=chromium:631539 TEST=None Committed: https://github.com/luci/luci-go/commit/2688a24cffb3a313527da327ee26fb583ac25c03

Patch Set 1 #

Patch Set 2 : deploytool: Add README.md, migrate docs to it. #

Patch Set 3 : Rename to "luci_deploy" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+500 lines, -6039 lines) Patch
D .luci-deploytool.cfg View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M README.md View 1 chunk +5 lines, -0 lines 0 comments Download
A deploytool/README.md View 1 2 1 chunk +478 lines, -0 lines 0 comments Download
M deploytool/api/deploy/checkout.proto View 1 2 1 chunk +1 line, -1 line 0 comments Download
M deploytool/api/deploy/checkout.pb.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M deploytool/api/deploy/config.proto View 1 2 3 chunks +6 lines, -43 lines 0 comments Download
M deploytool/api/deploy/config.pb.go View 1 2 3 chunks +6 lines, -43 lines 0 comments Download
D deploytool/cmd/build.go View 1 1 chunk +0 lines, -106 lines 0 comments Download
M deploytool/cmd/checkout.go View 1 1 chunk +0 lines, -675 lines 0 comments Download
M deploytool/cmd/config.go View 1 1 chunk +0 lines, -40 lines 0 comments Download
D deploytool/cmd/deploy.go View 1 1 chunk +0 lines, -469 lines 0 comments Download
D deploytool/cmd/deploy_appengine.go View 1 1 chunk +0 lines, -810 lines 0 comments Download
D deploytool/cmd/deploy_container_engine.go View 1 1 chunk +0 lines, -677 lines 0 comments Download
M deploytool/cmd/doc.go View 1 1 chunk +0 lines, -325 lines 0 comments Download
D deploytool/cmd/kubernetes.go View 1 1 chunk +0 lines, -440 lines 0 comments Download
D deploytool/cmd/layout.go View 1 1 chunk +0 lines, -983 lines 0 comments Download
A + deploytool/cmd/luci_deploy/build.go View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + deploytool/cmd/luci_deploy/checkout.go View 1 2 2 chunks +5 lines, -1 line 0 comments Download
A + deploytool/cmd/luci_deploy/config.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + deploytool/cmd/luci_deploy/deploy.go View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + deploytool/cmd/luci_deploy/deploy_appengine.go View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + deploytool/cmd/luci_deploy/deploy_container_engine.go View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A deploytool/cmd/luci_deploy/doc.go View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
A + deploytool/cmd/luci_deploy/kubernetes.go View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + deploytool/cmd/luci_deploy/layout.go View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + deploytool/cmd/luci_deploy/main.go View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + deploytool/cmd/luci_deploy/manage.go View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + deploytool/cmd/luci_deploy/param.go View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + deploytool/cmd/luci_deploy/path.go View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + deploytool/cmd/luci_deploy/staging.go View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + deploytool/cmd/luci_deploy/title.go View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + deploytool/cmd/luci_deploy/tools.go View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + deploytool/cmd/luci_deploy/util.go View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + deploytool/cmd/luci_deploy/version.go View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + deploytool/cmd/luci_deploy/version_test.go View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + deploytool/cmd/luci_deploy/work.go View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D deploytool/cmd/main.go View 1 1 chunk +0 lines, -120 lines 0 comments Download
D deploytool/cmd/manage.go View 1 1 chunk +0 lines, -235 lines 0 comments Download
D deploytool/cmd/param.go View 1 1 chunk +0 lines, -51 lines 0 comments Download
D deploytool/cmd/path.go View 1 1 chunk +0 lines, -66 lines 0 comments Download
D deploytool/cmd/staging.go View 1 1 chunk +0 lines, -83 lines 0 comments Download
D deploytool/cmd/title.go View 1 1 chunk +0 lines, -47 lines 0 comments Download
D deploytool/cmd/tools.go View 1 1 chunk +0 lines, -220 lines 0 comments Download
D deploytool/cmd/util.go View 1 1 chunk +0 lines, -126 lines 0 comments Download
D deploytool/cmd/version.go View 1 1 chunk +0 lines, -127 lines 0 comments Download
D deploytool/cmd/version_test.go View 1 1 chunk +0 lines, -63 lines 0 comments Download
D deploytool/cmd/work.go View 1 1 chunk +0 lines, -298 lines 0 comments Download
A + luci-deploy.cfg View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
dnj
PTAL
4 years, 4 months ago (2016-07-26 18:07:12 UTC) #3
estaab
lgtm
4 years, 4 months ago (2016-07-26 23:53:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182213002/20001
4 years, 4 months ago (2016-07-27 02:13:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Luci-go Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3042f2a9f626ba10)
4 years, 4 months ago (2016-07-27 02:19:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182213002/40001
4 years, 4 months ago (2016-07-27 02:28:30 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 02:36:02 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/2688a24cffb3a313527da327ee26fb583ac25c03

Powered by Google App Engine
This is Rietveld 408576698