Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: media/renderers/mock_gpu_video_accelerator_factories.cc

Issue 2182183007: Handle scaling frames in RTCVideoEncoder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add unittests. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/renderer/media/gpu/rtc_video_encoder_unittest.cc ('K') | « media/media.gyp ('k') | media/video/mock_video_encode_accelerator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/renderers/mock_gpu_video_accelerator_factories.cc
diff --git a/media/renderers/mock_gpu_video_accelerator_factories.cc b/media/renderers/mock_gpu_video_accelerator_factories.cc
index 603839b619c9e3e920e7ce1fbbf90219e3c81a41..56e34b1761b60a06087d10eb6b2b836ebe407d98 100644
--- a/media/renderers/mock_gpu_video_accelerator_factories.cc
+++ b/media/renderers/mock_gpu_video_accelerator_factories.cc
@@ -101,7 +101,9 @@ MockGpuVideoAcceleratorFactories::AllocateGpuMemoryBuffer(
std::unique_ptr<base::SharedMemory>
MockGpuVideoAcceleratorFactories::CreateSharedMemory(size_t size) {
- return nullptr;
+ std::unique_ptr<base::SharedMemory> shared_memory(new base::SharedMemory);
+ shared_memory->CreateAndMapAnonymous(size);
Pawel Osciak 2016/07/28 01:48:08 Should we check return value?
emircan 2016/07/28 19:35:45 Done.
+ return shared_memory;
}
std::unique_ptr<VideoDecodeAccelerator>
« content/renderer/media/gpu/rtc_video_encoder_unittest.cc ('K') | « media/media.gyp ('k') | media/video/mock_video_encode_accelerator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698