[interpreter] Support on-stack replacement in profiler.

[interpreter] Support on-stack replacement in profiler.

This adds preliminary support for on-stack replacement from Ignition to
optimized code generated by TurboFan to the runtime profiler. Involved
heuristics (e.g. code size allowance) have been taken from existing code
without any re-evaluation in the new setting.

R=rmcilroy@chromium.org
BUG=v8:4764
Committed: https://crrev.com/de244af9ba72f9707b9df18842fe351f2ab3164c
Cr-Commit-Position: refs/heads/master@{#38159}

[Michael Starzinger, 2016-07-27 10:17:38]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 10:17:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Starzinger, 2016-07-27 10:36:05]

Description was changed from

==========
[interpreter] Support on-stack replacement in profiler.

This adds preliminary support for on-stack replacement from Ignition to
optimized code generated by TurboFan to the runtime profiler. Involved
heuristics (e.g. code size allowance) have been taken from existing code
without any re-evaluation in the new setting.

R=
BUG=v8:4764
==========

to

==========
[interpreter] Support on-stack replacement in profiler.

This adds preliminary support for on-stack replacement from Ignition to
optimized code generated by TurboFan to the runtime profiler. Involved
heuristics (e.g. code size allowance) have been taken from existing code
without any re-evaluation in the new setting.

R=rmcilroy@chromium.org
BUG=v8:4764
==========

[Michael Starzinger, 2016-07-27 10:36:06]

mstarzinger@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[commit-bot: I haz the power, 2016-07-27 10:39:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 10:39:35]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-07-28 16:19:21]

LGTM with comments.

https://codereview.chromium.org/2182183005/diff/1/src/runtime-profiler.cc
File src/runtime-profiler.cc (right):

https://codereview.chromium.org/2182183005/diff/1/src/runtime-profiler.cc#new...
src/runtime-profiler.cc:281: int ticks = shared->profiler_ticks();
no need for this - just use ticks which is already read above

https://codereview.chromium.org/2182183005/diff/1/src/runtime-profiler.cc#new...
src/runtime-profiler.cc:284: static_cast<int64_t>(ticks) *
kOSRCodeSizeAllowancePerTick;
kOSRCodeSizeAllowanceBase and kOSRCodeSizeAllowancePerTick are based on
FullCodeGenerator::kCodeSizeMultiplier. We should probably base this on  the
kCodeSizeMultiplier used by Interpreter::InterruptBudget(), which is sized to
make bytecode equivalent to the multiplied FCG code size.

[Michael Starzinger, 2016-07-28 17:35:18]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 17:35:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Starzinger, 2016-07-28 17:57:24]

Thanks! Comments addressed. Will land tomorrow.

https://codereview.chromium.org/2182183005/diff/1/src/runtime-profiler.cc
File src/runtime-profiler.cc (right):

https://codereview.chromium.org/2182183005/diff/1/src/runtime-profiler.cc#new...
src/runtime-profiler.cc:281: int ticks = shared->profiler_ticks();
On 2016/07/28 16:19:21, rmcilroy (OOO) wrote:
> no need for this - just use ticks which is already read above

Done.

https://codereview.chromium.org/2182183005/diff/1/src/runtime-profiler.cc#new...
src/runtime-profiler.cc:284: static_cast<int64_t>(ticks) *
kOSRCodeSizeAllowancePerTick;
On 2016/07/28 16:19:21, rmcilroy (OOO) wrote:
> kOSRCodeSizeAllowanceBase and kOSRCodeSizeAllowancePerTick are based on
> FullCodeGenerator::kCodeSizeMultiplier. We should probably base this on  the
> kCodeSizeMultiplier used by Interpreter::InterruptBudget(), which is sized to
> make bytecode equivalent to the multiplied FCG code size.

Done.

[commit-bot: I haz the power, 2016-07-28 17:59:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 17:59:13]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-07-29 08:28:15]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-07-29 08:28:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2182183005/#ps20001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2016-07-29 08:28:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 08:29:54]

Description was changed from

==========
[interpreter] Support on-stack replacement in profiler.

This adds preliminary support for on-stack replacement from Ignition to
optimized code generated by TurboFan to the runtime profiler. Involved
heuristics (e.g. code size allowance) have been taken from existing code
without any re-evaluation in the new setting.

R=rmcilroy@chromium.org
BUG=v8:4764
==========

to

==========
[interpreter] Support on-stack replacement in profiler.

This adds preliminary support for on-stack replacement from Ignition to
optimized code generated by TurboFan to the runtime profiler. Involved
heuristics (e.g. code size allowance) have been taken from existing code
without any re-evaluation in the new setting.

R=rmcilroy@chromium.org
BUG=v8:4764
==========

[commit-bot: I haz the power, 2016-07-29 08:29:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-29 08:32:26]

Description was changed from

==========
[interpreter] Support on-stack replacement in profiler.

This adds preliminary support for on-stack replacement from Ignition to
optimized code generated by TurboFan to the runtime profiler. Involved
heuristics (e.g. code size allowance) have been taken from existing code
without any re-evaluation in the new setting.

R=rmcilroy@chromium.org
BUG=v8:4764
==========

to

==========
[interpreter] Support on-stack replacement in profiler.

This adds preliminary support for on-stack replacement from Ignition to
optimized code generated by TurboFan to the runtime profiler. Involved
heuristics (e.g. code size allowance) have been taken from existing code
without any re-evaluation in the new setting.

R=rmcilroy@chromium.org
BUG=v8:4764

Committed: https://crrev.com/de244af9ba72f9707b9df18842fe351f2ab3164c
Cr-Commit-Position: refs/heads/master@{#38159}
==========

[commit-bot: I haz the power, 2016-07-29 08:32:27]

Patchset 2 (id:??) landed as
https://crrev.com/de244af9ba72f9707b9df18842fe351f2ab3164c
Cr-Commit-Position: refs/heads/master@{#38159}