Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2182183003: Remove |TouchEvent.initTouchEvent()| in M54 (Closed)

Created:
4 years, 4 months ago by chongz
Modified:
4 years, 4 months ago
CC:
chromium-reviews, blink-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove |TouchEvent.initTouchEvent()| in M54 |TouchEvent.initTouchEvent()| is not standardized and not interoperate with Firefox or Safari. Developers should be encouraged to use the new TouchEvent constructor instead. |initTouchEvent()| was deprecated in M49, and this CL removes it in M54 (deferred from M53). Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/dqlJguVuIHs Chrome Status Entry: https://www.chromestatus.com/features/5730982598541312 TBR=timvolodine BUG=522100 Committed: https://crrev.com/44cc3124a56262d937b36a3d6d0d3de626082716 Cr-Commit-Position: refs/heads/master@{#408579}

Patch Set 1 #

Messages

Total messages: 37 (21 generated)
chongz
bokan@ PTAL, thanks!
4 years, 4 months ago (2016-07-26 21:56:33 UTC) #9
bokan
lgtm. Good riddance.
4 years, 4 months ago (2016-07-26 23:21:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182183003/1
4 years, 4 months ago (2016-07-27 02:50:36 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/225817)
4 years, 4 months ago (2016-07-27 02:55:44 UTC) #14
chongz
jam@ PTAL at this CL to remove |TouchEvent.initTouchEvent()|, thanks! (seems I'm missing OWNER for "stable/webexposed/global-interface-listing-expected.txt")
4 years, 4 months ago (2016-07-27 03:05:49 UTC) #16
jam
On 2016/07/27 03:05:49, chongz wrote: > jam@ PTAL at this CL to remove |TouchEvent.initTouchEvent()|, thanks! ...
4 years, 4 months ago (2016-07-27 17:41:26 UTC) #17
chongz
rbyers@ PTAL, thanks!
4 years, 4 months ago (2016-07-27 17:50:31 UTC) #19
WRONG-USE-chromium
LGTM
4 years, 4 months ago (2016-07-28 00:26:54 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182183003/1
4 years, 4 months ago (2016-07-28 18:04:35 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/227144)
4 years, 4 months ago (2016-07-28 18:10:23 UTC) #26
chongz
rbyers@ the bot says I'm still missing owners... Maybe it's because you LGTMed from the ...
4 years, 4 months ago (2016-07-28 18:23:33 UTC) #27
Rick Byers
On 2016/07/28 18:23:33, chongz wrote: > rbyers@ the bot says I'm still missing owners... Maybe ...
4 years, 4 months ago (2016-07-29 05:27:17 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182183003/1
4 years, 4 months ago (2016-07-29 05:28:01 UTC) #32
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 05:31:02 UTC) #34
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/44cc3124a56262d937b36a3d6d0d3de626082716 Cr-Commit-Position: refs/heads/master@{#408579}
4 years, 4 months ago (2016-07-29 05:33:00 UTC) #36
timvolodine
4 years, 4 months ago (2016-07-29 14:02:05 UTC) #37
Message was sent while issue was closed.
On 2016/07/29 05:27:17, Rick Byers (slow until Aug 1) wrote:
> On 2016/07/28 18:23:33, chongz wrote:
> > rbyers@ the bot says I'm still missing owners... Maybe it's because you
LGTMed
> > from the @google.com email?
> 
> You need timvolodine@ on the android_webview/ change (he's the only OWNER
> there).  But those changes are totally to be expected along with the other
> webexposed changes, so I think TBR is fine (separately I'll discuss adding
> API_OWNERS to that directory).

yes indeed, rs lgtm android_webview/..

(technically top-level android_webview/ owners can also approve)

Powered by Google App Engine
This is Rietveld 408576698