Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 2182163002: Don't unnecessarily resize windows in sk_app on X (Closed)

Created:
4 years, 4 months ago by bsalomon
Modified:
4 years, 4 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M tools/viewer/sk_app/Window.h View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/viewer/sk_app/unix/Window_unix.h View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
bsalomon
Clicking the title bar and other actions can cause ConfigureNotify messages even though the window ...
4 years, 4 months ago (2016-07-26 15:07:02 UTC) #3
jvanverth1
lgtm
4 years, 4 months ago (2016-07-26 15:18:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182163002/1
4 years, 4 months ago (2016-07-26 15:25:55 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 15:50:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/eeb4c387ddd8e52c760b4e4c9fcc6593ccba17be

Powered by Google App Engine
This is Rietveld 408576698