Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2182133004: Making webapk service java appear in only one .jar (Closed)

Created:
4 years, 4 months ago by smaier
Modified:
4 years, 4 months ago
Reviewers:
pkotwicz, Yaron, agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Making webapk service java appear in only one .jar. This is a prerequisite for some proguard-related test changes. It did not like that the same class appeared in both the test code and the app's code. BUG=None R=pkotwicz,yfriedman,agrieve TBR=pkotwicz Added base deps to javatest Committed: https://crrev.com/20e6f2f2fd3582499c3fad7de0d181a219c3d010 Cr-Commit-Position: refs/heads/master@{#409922}

Patch Set 1 #

Patch Set 2 : Compiling #

Patch Set 3 : all targets compiling #

Patch Set 4 : added comment to aidl_java rule #

Patch Set 5 : Disabling broken tests #

Patch Set 6 : fixing checkdeps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -9 lines) Patch
M chrome/android/BUILD.gn View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/webapk/libs/client/BUILD.gn View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/android/webapk/libs/runtime_library/BUILD.gn View 1 2 3 4 chunks +11 lines, -2 lines 0 comments Download
M chrome/android/webapk/libs/runtime_library/javatests/DEPS View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/webapk/libs/runtime_library/javatests/src/org/chromium/webapk/lib/runtime_library/WebApkServiceImplTest.java View 1 2 3 4 3 chunks +9 lines, -3 lines 0 comments Download
M chrome/test/android/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 27 (15 generated)
smaier
pkotwicz@chromium.org: Please review changes in webapk yfriedman@chromium.org: Please review all changes
4 years, 4 months ago (2016-07-27 14:22:18 UTC) #4
agrieve
On 2016/07/27 14:22:18, smaier wrote: > mailto:pkotwicz@chromium.org: Please review changes in webapk > > mailto:yfriedman@chromium.org: ...
4 years, 4 months ago (2016-07-27 14:28:22 UTC) #6
pkotwicz
LGTM
4 years, 4 months ago (2016-07-28 18:32:54 UTC) #7
Yaron
lgtm
4 years, 4 months ago (2016-08-02 19:14:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182133004/60001
4 years, 4 months ago (2016-08-02 19:20:26 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/114668)
4 years, 4 months ago (2016-08-02 21:06:39 UTC) #13
pkotwicz
LGTM Disabling the test is OK given that it can be re-enabled with follow up ...
4 years, 4 months ago (2016-08-04 18:36:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182133004/80001
4 years, 4 months ago (2016-08-04 18:37:46 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/274485)
4 years, 4 months ago (2016-08-04 19:55:52 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182133004/100001
4 years, 4 months ago (2016-08-04 21:42:54 UTC) #23
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 4 months ago (2016-08-04 22:47:45 UTC) #25
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 22:49:11 UTC) #27
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/20e6f2f2fd3582499c3fad7de0d181a219c3d010
Cr-Commit-Position: refs/heads/master@{#409922}

Powered by Google App Engine
This is Rietveld 408576698