Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2182113002: PPC: Fixed RememberedSetRemoveRange to have chunk->size > PageSize (Closed)

Created:
4 years, 4 months ago by JaideepBajwa
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Fixed RememberedSetRemoveRange to have chunk->size > PageSize Increased array size in the testcase such that the chunk size is greater that the page size on PPC (4MB). This fixes the case when (start + Page::kPageSize) memory location is tested to be part of the chunk. The testcase was added as part of https://codereview.chromium.org/2110213003/ R=ulan@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/d05c2f02c5917c06373feeb3a6b4a8cf53f91b97 Cr-Commit-Position: refs/heads/master@{#38060}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Calculate array size based on PageSize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M test/cctest/heap/test-heap.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
JaideepBajwa
PTAL.
4 years, 4 months ago (2016-07-26 13:41:39 UTC) #1
ulan
https://codereview.chromium.org/2182113002/diff/1/test/cctest/heap/test-heap.cc File test/cctest/heap/test-heap.cc (right): https://codereview.chromium.org/2182113002/diff/1/test/cctest/heap/test-heap.cc#newcode6842 test/cctest/heap/test-heap.cc:6842: Handle<FixedArray> array = isolate->factory()->NewFixedArray(500000); Instead of ifdef, maybe we ...
4 years, 4 months ago (2016-07-26 13:45:32 UTC) #2
JaideepBajwa
On 2016/07/26 13:45:32, ulan wrote: > https://codereview.chromium.org/2182113002/diff/1/test/cctest/heap/test-heap.cc > File test/cctest/heap/test-heap.cc (right): > > https://codereview.chromium.org/2182113002/diff/1/test/cctest/heap/test-heap.cc#newcode6842 > ...
4 years, 4 months ago (2016-07-26 14:22:53 UTC) #3
ulan
LGTM, thanks for fixing!
4 years, 4 months ago (2016-07-26 14:43:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182113002/20001
4 years, 4 months ago (2016-07-26 14:44:41 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-26 15:07:55 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 15:10:24 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d05c2f02c5917c06373feeb3a6b4a8cf53f91b97
Cr-Commit-Position: refs/heads/master@{#38060}

Powered by Google App Engine
This is Rietveld 408576698