Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: src/ic/ic-compiler.cc

Issue 2182103002: [KeyedLoadIC] Support Smi "handlers" for simple field loads (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic/ic-compiler.h ('k') | src/type-feedback-vector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic/ic-compiler.cc
diff --git a/src/ic/ic-compiler.cc b/src/ic/ic-compiler.cc
index af025fbafd0c71f69e8c5a0000c8b8c97894e187..2f0633e0d87948b0108f24927ffb01a7fb6ccbb9 100644
--- a/src/ic/ic-compiler.cc
+++ b/src/ic/ic-compiler.cc
@@ -10,42 +10,6 @@
namespace v8 {
namespace internal {
-
-Handle<Code> PropertyICCompiler::ComputeKeyedLoadMonomorphicHandler(
- Handle<Map> receiver_map, ExtraICState extra_ic_state) {
- // TODO(ishell): remove extra_ic_state
- Isolate* isolate = receiver_map->GetIsolate();
- bool is_js_array = receiver_map->instance_type() == JS_ARRAY_TYPE;
- ElementsKind elements_kind = receiver_map->elements_kind();
-
- // No need to check for an elements-free prototype chain here, the generated
- // stub code needs to check that dynamically anyway.
- bool convert_hole_to_undefined =
- is_js_array && elements_kind == FAST_HOLEY_ELEMENTS &&
- *receiver_map == isolate->get_initial_js_array_map(elements_kind);
- Handle<Code> stub;
- if (receiver_map->has_indexed_interceptor()) {
- TRACE_HANDLER_STATS(isolate, KeyedLoadIC_LoadIndexedInterceptorStub);
- stub = LoadIndexedInterceptorStub(isolate).GetCode();
- } else if (receiver_map->IsStringMap()) {
- TRACE_HANDLER_STATS(isolate, KeyedLoadIC_LoadIndexedStringStub);
- stub = LoadIndexedStringStub(isolate).GetCode();
- } else if (receiver_map->has_sloppy_arguments_elements()) {
- TRACE_HANDLER_STATS(isolate, KeyedLoadIC_KeyedLoadSloppyArgumentsStub);
- stub = KeyedLoadSloppyArgumentsStub(isolate).GetCode();
- } else if (receiver_map->has_fast_elements() ||
- receiver_map->has_fixed_typed_array_elements()) {
- TRACE_HANDLER_STATS(isolate, KeyedLoadIC_LoadFastElementStub);
- stub = LoadFastElementStub(isolate, is_js_array, elements_kind,
- convert_hole_to_undefined).GetCode();
- } else {
- DCHECK(receiver_map->has_dictionary_elements());
- TRACE_HANDLER_STATS(isolate, KeyedLoadIC_LoadDictionaryElementStub);
- stub = LoadDictionaryElementStub(isolate).GetCode();
- }
- return stub;
-}
-
Handle<Code> PropertyICCompiler::ComputeKeyedStoreMonomorphicHandler(
Handle<Map> receiver_map, KeyedAccessStoreMode store_mode) {
Isolate* isolate = receiver_map->GetIsolate();
« no previous file with comments | « src/ic/ic-compiler.h ('k') | src/type-feedback-vector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698