Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: src/code-stubs.cc

Issue 2182103002: [KeyedLoadIC] Support Smi "handlers" for simple field loads (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: implement KeyedLoadIC stub in CodeStubAssembler Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/code-stubs.h" 5 #include "src/code-stubs.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 451 matching lines...) Expand 10 before | Expand all | Expand 10 after
462 462
463 Node* slot = assembler->Parameter(0); 463 Node* slot = assembler->Parameter(0);
464 Node* vector = assembler->Parameter(1); 464 Node* vector = assembler->Parameter(1);
465 Node* context = assembler->Parameter(2); 465 Node* context = assembler->Parameter(2);
466 466
467 CodeStubAssembler::LoadICParameters p(context, nullptr, nullptr, slot, 467 CodeStubAssembler::LoadICParameters p(context, nullptr, nullptr, slot,
468 vector); 468 vector);
469 assembler->LoadGlobalIC(&p); 469 assembler->LoadGlobalIC(&p);
470 } 470 }
471 471
472 void KeyedLoadICTrampolineTFStub::GenerateAssembly(
473 CodeStubAssembler* assembler) const {
474 typedef compiler::Node Node;
475
476 Node* receiver = assembler->Parameter(0);
Igor Sheludko 2016/07/26 16:25:11 Please use Descriptor::ParameterIndices constants.
Jakob Kummerow 2016/07/26 17:10:40 Done.
477 Node* name = assembler->Parameter(1);
478 Node* slot = assembler->Parameter(2);
479 Node* context = assembler->Parameter(3);
480 Node* vector = assembler->LoadTypeFeedbackVectorForStub();
481
482 CodeStubAssembler::LoadICParameters p(context, receiver, name, slot, vector);
483 assembler->KeyedLoadIC(&p);
484 }
485
486 void KeyedLoadICTFStub::GenerateAssembly(CodeStubAssembler* assembler) const {
487 typedef compiler::Node Node;
488
489 Node* receiver = assembler->Parameter(0);
Igor Sheludko 2016/07/26 16:25:11 Same here.
Jakob Kummerow 2016/07/26 17:10:40 Done.
490 Node* name = assembler->Parameter(1);
491 Node* slot = assembler->Parameter(2);
492 Node* vector = assembler->Parameter(3);
493 Node* context = assembler->Parameter(4);
494
495 CodeStubAssembler::LoadICParameters p(context, receiver, name, slot, vector);
496 assembler->KeyedLoadIC(&p);
497 }
498
472 void AllocateHeapNumberStub::GenerateAssembly( 499 void AllocateHeapNumberStub::GenerateAssembly(
473 CodeStubAssembler* assembler) const { 500 CodeStubAssembler* assembler) const {
474 typedef compiler::Node Node; 501 typedef compiler::Node Node;
475 502
476 Node* result = assembler->AllocateHeapNumber(); 503 Node* result = assembler->AllocateHeapNumber();
477 assembler->Return(result); 504 assembler->Return(result);
478 } 505 }
479 506
480 #define SIMD128_GEN_ASM(TYPE, Type, type, lane_count, lane_type) \ 507 #define SIMD128_GEN_ASM(TYPE, Type, type, lane_count, lane_type) \
481 void Allocate##Type##Stub::GenerateAssembly(CodeStubAssembler* assembler) \ 508 void Allocate##Type##Stub::GenerateAssembly(CodeStubAssembler* assembler) \
(...skipping 4380 matching lines...) Expand 10 before | Expand all | Expand 10 after
4862 if (type->Is(Type::UntaggedPointer())) { 4889 if (type->Is(Type::UntaggedPointer())) {
4863 return Representation::External(); 4890 return Representation::External();
4864 } 4891 }
4865 4892
4866 DCHECK(!type->Is(Type::Untagged())); 4893 DCHECK(!type->Is(Type::Untagged()));
4867 return Representation::Tagged(); 4894 return Representation::Tagged();
4868 } 4895 }
4869 4896
4870 } // namespace internal 4897 } // namespace internal
4871 } // namespace v8 4898 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698