Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2182093002: [GN] Prefer explicit pool to automatic link_pool for link targets. (Closed)

Created:
4 years, 4 months ago by sdefresne
Modified:
4 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GN] Prefer explicit pool to automatic link_pool for link targets. In preparation of refactoring the concurrent_links code to use explicit pools, prefer to use an explicit pool if defined over the automatic link_pool for link targets. BUG=612786 Committed: https://crrev.com/1c27131e1bf77b059ef4c4f444bdccecdddeb0f6 Cr-Commit-Position: refs/heads/master@{#408077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M tools/gn/ninja_toolchain_writer.cc View 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sdefresne
Please take a look.
4 years, 4 months ago (2016-07-26 13:33:17 UTC) #4
brettw
lgtm
4 years, 4 months ago (2016-07-26 18:15:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182093002/1
4 years, 4 months ago (2016-07-27 08:43:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 08:46:14 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 08:47:20 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c27131e1bf77b059ef4c4f444bdccecdddeb0f6
Cr-Commit-Position: refs/heads/master@{#408077}

Powered by Google App Engine
This is Rietveld 408576698