Set correct default icu data file for big endian

Set correct default icu data file for big endian

Default icu data file for all architectures was set to icudtl.dat, for
big endian this should be icudtb.dat. This will fix intl tests for big
endian once v8 rolls to a newer version of icu that supports big endian.

BUG=
TEST=intl/*

Committed: https://crrev.com/9a1832a829f2eba3fb9c55daec6021518eb8c558
Cr-Commit-Position: refs/heads/master@{#38102}

[miran.karic, 2016-07-26 09:19:40]

miran.karic@imgtec.com changed reviewers:
+ akos.palfi@imgtec.com, ivica.bogosavljevic@imgtec.com

[miran.karic, 2016-07-26 09:19:40]

PTAL

[ivica.bogosavljevic, 2016-07-27 08:50:52]

ivica.bogosavljevic@imgtec.com changed reviewers:
+ jochen@chromium.org, machenbach@chromium.org

[ivica.bogosavljevic, 2016-07-27 08:50:53]

Can please someone take a look ?

[Michael Achenbach, 2016-07-27 08:58:03]

lgtm ~ comment

https://codereview.chromium.org/2182043002/diff/1/src/icu_util.cc
File src/icu_util.cc (right):

https://codereview.chromium.org/2182043002/diff/1/src/icu_util.cc#newcode53
src/icu_util.cc:53: #if __BYTE_ORDER == __LITTLE_ENDIAN
nit: Maybe synonym, I don't know, but in other places we use the pattern and
message:

#if defined(V8_TARGET_LITTLE_ENDIAN)

#elif defined(V8_TARGET_BIG_ENDIAN)

#else
#error Unknown byte ordering
#endif

Prefer consistency.

[miran.karic, 2016-07-27 13:32:16]

https://codereview.chromium.org/2182043002/diff/1/src/icu_util.cc
File src/icu_util.cc (right):

https://codereview.chromium.org/2182043002/diff/1/src/icu_util.cc#newcode53
src/icu_util.cc:53: #if __BYTE_ORDER == __LITTLE_ENDIAN
After including "src/base/build_config.h" this works, done.

On 2016/07/27 08:58:03, Michael Achenbach (slow) wrote:
> nit: Maybe synonym, I don't know, but in other places we use the pattern and
> message:
> 
> #if defined(V8_TARGET_LITTLE_ENDIAN)
> 
> #elif defined(V8_TARGET_BIG_ENDIAN)
> 
> #else
> #error Unknown byte ordering
> #endif
> 
> Prefer consistency.

[Michael Achenbach, 2016-07-27 14:00:29]

lgtm

[miran.karic, 2016-07-27 14:14:30]

The CQ bit was checked by miran.karic@imgtec.com

[commit-bot: I haz the power, 2016-07-27 14:14:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 14:37:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-27 14:39:06]

Description was changed from

==========
Set correct default icu data file for big endian

Default icu data file for all architectures was set to icudtl.dat, for
big endian this should be icudtb.dat. This will fix intl tests for big
endian once v8 rolls to a newer version of icu that supports big endian.

BUG=
TEST=intl/*
==========

to

==========
Set correct default icu data file for big endian

Default icu data file for all architectures was set to icudtl.dat, for
big endian this should be icudtb.dat. This will fix intl tests for big
endian once v8 rolls to a newer version of icu that supports big endian.

BUG=
TEST=intl/*

Committed: https://crrev.com/9a1832a829f2eba3fb9c55daec6021518eb8c558
Cr-Commit-Position: refs/heads/master@{#38102}
==========

[commit-bot: I haz the power, 2016-07-27 14:39:07]

Patchset 2 (id:??) landed as
https://crrev.com/9a1832a829f2eba3fb9c55daec6021518eb8c558
Cr-Commit-Position: refs/heads/master@{#38102}