Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2182013002: Convert editing/pasteboard/merge-after-delete*.html to use w3c test harness (Closed)

Created:
4 years, 5 months ago by yosin_UTC9
Modified:
4 years, 4 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/pasteboard/merge-after-delete*.html to use w3c test harness This patch converts "editing/pasteboard/merge-after-delete*.html" to use w3c test harness and consolidates into "merge_after_delete.html" to simplify test case for ease of maintenance. This patch is a preparation of getting rid of grammar checking feature. BUG=619452 TEST=n/a; this patch changes a test file Committed: https://crrev.com/1004d071d629d70592d69700a5d388e1a526559e Cr-Commit-Position: refs/heads/master@{#408027}

Patch Set 1 : 2016-07-26T16:15:35 #

Total comments: 2

Patch Set 2 : 2016-07-27T10:40:52 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -324 lines) Patch
A third_party/WebKit/LayoutTests/editing/inserting/merge_after_delete.html View 1 1 chunk +44 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/pasteboard/merge-after-delete.html View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/pasteboard/merge-after-delete-1.html View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/pasteboard/merge-after-delete-2.html View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/merge-after-delete-1-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/merge-after-delete-1-expected.txt View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/merge-after-delete-2-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/merge-after-delete-2-expected.txt View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/merge-after-delete-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/merge-after-delete-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/merge-after-delete-1-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/merge-after-delete-1-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/merge-after-delete-2-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/merge-after-delete-2-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/merge-after-delete-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/merge-after-delete-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/merge-after-delete-1-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/merge-after-delete-1-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/merge-after-delete-2-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/merge-after-delete-2-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/merge-after-delete-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/merge-after-delete-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
yosin_UTC9
PTAL
4 years, 5 months ago (2016-07-26 08:27:14 UTC) #5
Xiaocheng
https://codereview.chromium.org/2182013002/diff/1/third_party/WebKit/LayoutTests/editing/inserting/merge_after_delete.html File third_party/WebKit/LayoutTests/editing/inserting/merge_after_delete.html (right): https://codereview.chromium.org/2182013002/diff/1/third_party/WebKit/LayoutTests/editing/inserting/merge_after_delete.html#newcode16 third_party/WebKit/LayoutTests/editing/inserting/merge_after_delete.html:16: '<div style="color:blue">baz|</div>', <br> is missing.
4 years, 4 months ago (2016-07-26 09:43:35 UTC) #8
yosin_UTC9
PTAL Update test case; adding missing BR in input sample. https://codereview.chromium.org/2182013002/diff/1/third_party/WebKit/LayoutTests/editing/inserting/merge_after_delete.html File third_party/WebKit/LayoutTests/editing/inserting/merge_after_delete.html (right): https://codereview.chromium.org/2182013002/diff/1/third_party/WebKit/LayoutTests/editing/inserting/merge_after_delete.html#newcode16 ...
4 years, 4 months ago (2016-07-27 01:45:37 UTC) #11
Xiaocheng
lgtm
4 years, 4 months ago (2016-07-27 02:05:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2182013002/20001
4 years, 4 months ago (2016-07-27 02:11:14 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-27 02:57:45 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 03:00:37 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1004d071d629d70592d69700a5d388e1a526559e
Cr-Commit-Position: refs/heads/master@{#408027}

Powered by Google App Engine
This is Rietveld 408576698