Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2181983002: Revert "Speculatively launch Service Workers on mouse/touch events. [3/5]" (Closed)

Created:
4 years, 5 months ago by dominickn
Modified:
4 years, 5 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, asvitkine+watch_chromium.org, horo+watch_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Speculatively launch Service Workers on mouse/touch events. [3/5]" This reverts commit 2cba6671596841c77457423e70e9d12070425dd1. Reason: Speculative revert so that crrev.com/2181553003 can be reverted. This may have caused crbug.com/631190. This CL will be relanded if reverting the dependent CL and re-enabling the disabled app banner data fetcher tests still causes failures on https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29 TBR=horo@chromium.org,jochen@chromium.org,nhiroki@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=631190 Committed: https://crrev.com/6cfda680d992933c594d0866eb2183600d98a2ed Cr-Commit-Position: refs/heads/master@{#407714}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -193 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.h View 3 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 4 chunks +5 lines, -16 lines 0 comments Download
M content/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.h View 3 chunks +0 lines, -26 lines 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.cc View 4 chunks +0 lines, -96 lines 0 comments Download
M content/browser/service_worker/service_worker_metrics.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_metrics.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M content/public/browser/service_worker_context.h View 2 chunks +0 lines, -16 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181983002/1
4 years, 5 months ago (2016-07-26 05:31:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-26 05:32:20 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-26 05:34:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6cfda680d992933c594d0866eb2183600d98a2ed
Cr-Commit-Position: refs/heads/master@{#407714}

Powered by Google App Engine
This is Rietveld 408576698