third_party/WebKit/Source/modules/accessibility/AXObject.cpp - Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObject.cpp

Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_move_computedstyle_around

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/style/ComputedStyle.h ('K') | « third_party/WebKit/Source/modules/accessibility/AXMediaControls.cpp ('k') | third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXObject.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXObject.cpp

index 8d029821a41d004ffdbc62327c7602d0cb5b0bdb..52288765e79cff7bf02048e3e84463cf1fee726f 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXObject.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXObject.cpp

@@ -760,7 +760,7 @@ bool AXObject::isHiddenForTextAlternativeCalculation() const

return false;

if (getLayoutObject())

- return getLayoutObject()->style()->visibility() != VISIBLE;

+ return getLayoutObject()->style()->visibility() != EVisibility::Visible;

// This is an obscure corner case: if a node has no LayoutObject, that means it's not rendered,

// but we still may be exploring it as part of a text alternative calculation, for example if it

@@ -770,7 +770,7 @@ bool AXObject::isHiddenForTextAlternativeCalculation() const

Document* doc = getDocument();

if (doc && doc->frame() && getNode() && getNode()->isElementNode()) {

RefPtr<ComputedStyle> style = doc->ensureStyleResolver().styleForElement(toElement(getNode()));

- return style->display() == NONE || style->visibility() != VISIBLE;

+ return style->display() == NONE || style->visibility() != EVisibility::Visible;

}

return false;