third_party/WebKit/Source/core/paint/TablePainter.cpp - Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/TablePainter.cpp

Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_move_computedstyle_around

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp ('K') | « third_party/WebKit/Source/core/paint/TableCellPainter.cpp ('k') | third_party/WebKit/Source/core/style/ComputedStyle.h » ('j') | third_party/WebKit/Source/core/style/ComputedStyle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/TablePainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/TablePainter.cpp b/third_party/WebKit/Source/core/paint/TablePainter.cpp

index 0beb002faec1c26056f8a66581faddee09d52456..c020a9849fa18844c242d1358db7e89af662b3db 100644

--- a/third_party/WebKit/Source/core/paint/TablePainter.cpp

+++ b/third_party/WebKit/Source/core/paint/TablePainter.cpp

@@ -41,7 +41,7 @@ void TablePainter::paintObject(const PaintInfo& paintInfo, const LayoutPoint& pa

}

- if (m_layoutTable.collapseBorders() && shouldPaintDescendantBlockBackgrounds(paintPhase) && m_layoutTable.style()->visibility() == VISIBLE) {

+ if (m_layoutTable.collapseBorders() && shouldPaintDescendantBlockBackgrounds(paintPhase) && m_layoutTable.style()->visibility() == EVisibility::Visible) {

// Using our cached sorted styles, we then do individual passes,

// painting each style of border from lowest precedence to highest precedence.

LayoutTable::CollapsedBorderValues collapsedBorders = m_layoutTable.collapsedBorders();

@@ -61,7 +61,7 @@ void TablePainter::paintObject(const PaintInfo& paintInfo, const LayoutPoint& pa

void TablePainter::paintBoxDecorationBackground(const PaintInfo& paintInfo, const LayoutPoint& paintOffset)

{

- if (!m_layoutTable.hasBoxDecorationBackground() || m_layoutTable.style()->visibility() != VISIBLE)

+ if (!m_layoutTable.hasBoxDecorationBackground() || m_layoutTable.style()->visibility() != EVisibility::Visible)

return;

LayoutRect rect(paintOffset, m_layoutTable.size());

@@ -71,7 +71,7 @@ void TablePainter::paintBoxDecorationBackground(const PaintInfo& paintInfo, cons

void TablePainter::paintMask(const PaintInfo& paintInfo, const LayoutPoint& paintOffset)

{

- if (m_layoutTable.style()->visibility() != VISIBLE || paintInfo.phase != PaintPhaseMask)

+ if (m_layoutTable.style()->visibility() != EVisibility::Visible || paintInfo.phase != PaintPhaseMask)

return;

if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(paintInfo.context, m_layoutTable, paintInfo.phase))