third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp - Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_move_computedstyle_around

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp ('K') | « third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp ('k') | third_party/WebKit/Source/core/paint/ListMarkerPainter.cpp » ('j') | third_party/WebKit/Source/core/style/ComputedStyle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp b/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

index f1a452fb2a64285bf788d484e954d9eeb5e6a16f..c31f32f8ff7e1e0482278bf8a0a377b733e9ad45 100644

--- a/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

@@ -238,7 +238,7 @@ bool InlineTextBoxPainter::shouldPaintTextBox(const PaintInfo& paintInfo)

// This code path is only called in PaintPhaseForeground whereas we would

// expect PaintPhaseSelection. The existing haveSelection logic in paint()

// tests for != PaintPhaseTextClip.

- if (m_inlineTextBox.getLineLayoutItem().style()->visibility() != VISIBLE

+ if (m_inlineTextBox.getLineLayoutItem().style()->visibility() != EVisibility::Visible

|| m_inlineTextBox.truncation() == cFullTruncation

|| !m_inlineTextBox.len())

return false;