third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.cpp - Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.cpp

Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_move_computedstyle_around

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp ('K') | « third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp » ('j') | third_party/WebKit/Source/core/style/ComputedStyle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.cpp

index beaa7b707cdaf6af7c19e5b0f9d7840abe3c3267..edb44bbb9a5bd7e2152acd4247f273be4b3e259d 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.cpp

@@ -81,7 +81,7 @@ PassRefPtr<const SkPicture> LayoutSVGResourceMasker::createContentPicture(Affine

if (!layoutObject)

continue;

const ComputedStyle* style = layoutObject->style();

- if (!style || style->display() == NONE || style->visibility() != VISIBLE)

+ if (!style || style->display() == NONE || style->visibility() != EVisibility::Visible)

continue;

SVGPaintContext::paintSubtree(pictureBuilder.context(), layoutObject);

@@ -98,7 +98,7 @@ void LayoutSVGResourceMasker::calculateMaskContentPaintInvalidationRect()

if (!layoutObject)

continue;

const ComputedStyle* style = layoutObject->style();

- if (!style || style->display() == NONE || style->visibility() != VISIBLE)

+ if (!style || style->display() == NONE || style->visibility() != EVisibility::Visible)

continue;

m_maskContentBoundaries.unite(layoutObject->localToSVGParentTransform().mapRect(layoutObject->paintInvalidationRectInLocalSVGCoordinates()));

}