third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_move_computedstyle_around

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutBlock.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp » ('j') | third_party/WebKit/Source/core/style/ComputedStyle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index 1a54060cdb116cbf69ab91aaed820321ecf42f93..01dfca74fef5c5cccd0228cda8f0175ac67314dd 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -1423,7 +1423,7 @@ static bool isCandidateForOpaquenessTest(const LayoutBox& childBox)

const ComputedStyle& childStyle = childBox.styleRef();

if (childStyle.position() != StaticPosition && childBox.containingBlock() != childBox.parent())

return false;

- if (childStyle.visibility() != VISIBLE || childStyle.shapeOutside())

+ if (childStyle.visibility() != EVisibility::Visible || childStyle.shapeOutside())

return false;

if (childBox.size().isZero())

return false;

@@ -2056,7 +2056,7 @@ bool LayoutBox::needsForcedBreakBefore(EBreak previousBreakAfterValue) const

LayoutRect LayoutBox::localOverflowRectForPaintInvalidation() const

{

- if (style()->visibility() != VISIBLE)

+ if (style()->visibility() != EVisibility::Visible)

return LayoutRect();

return selfVisualOverflowRect();

@@ -3879,7 +3879,7 @@ PositionWithAffinity LayoutBox::positionForPoint(const LayoutPoint& point)

for (LayoutObject* layoutObject = firstChild; layoutObject; layoutObject = layoutObject->nextSibling()) {

if ((!layoutObject->slowFirstChild() && !layoutObject->isInline() && !layoutObject->isLayoutBlockFlow() )

- || layoutObject->style()->visibility() != VISIBLE)

+ || layoutObject->style()->visibility() != EVisibility::Visible)

continue;

if (!layoutObject->isBox())