third_party/WebKit/Source/core/dom/Element.cpp - Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_move_computedstyle_around

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp ('K') | « third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp ('k') | third_party/WebKit/Source/core/editing/EditingUtilities.cpp » ('j') | third_party/WebKit/Source/core/style/ComputedStyle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/Element.cpp

diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp

index c45d0f8d8fa2cd4d9168851b0167eba458b3be1f..ce91c264a3b3728881d5265aa170b76b2e26912f 100644

--- a/third_party/WebKit/Source/core/dom/Element.cpp

+++ b/third_party/WebKit/Source/core/dom/Element.cpp

@@ -240,12 +240,12 @@ bool Element::layoutObjectIsFocusable() const

if (isInCanvasSubtree()) {

const HTMLCanvasElement* canvas = Traversal<HTMLCanvasElement>::firstAncestorOrSelf(*this);

DCHECK(canvas);

- return canvas->layoutObject() && canvas->layoutObject()->style()->visibility() == VISIBLE;

+ return canvas->layoutObject() && canvas->layoutObject()->style()->visibility() == EVisibility::Visible;

}

// FIXME: Even if we are not visible, we might have a child that is visible.

// Hyatt wants to fix that some day with a "has visible content" flag or the like.

- return layoutObject() && layoutObject()->style()->visibility() == VISIBLE;

+ return layoutObject() && layoutObject()->style()->visibility() == EVisibility::Visible;

}

Node* Element::cloneNode(bool deep)