third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelper.cpp - Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelper.cpp

Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_move_computedstyle_around

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp ('K') | « third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp » ('j') | third_party/WebKit/Source/core/style/ComputedStyle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelper.cpp

diff --git a/third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelper.cpp b/third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelper.cpp

index eef1bd10484024ce13e08f291794b3c82632aa72..ace2b8c3a6a643832bfc2c601336433e42273ba6 100644

--- a/third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelper.cpp

+++ b/third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelper.cpp

@@ -159,17 +159,17 @@ void PrintTo(const AnimatableVisibility& animVisibility, ::std::ostream* os)

{

*os << "AnimatableVisibility(";

switch (animVisibility.visibility()) {

- case VISIBLE:

- *os << "VISIBLE";

+ case EVisibility::Visible:

+ *os << "EVisibility::Visible";

break;

- case HIDDEN:

- *os << "HIDDEN";

+ case EVisibility::Hidden:

+ *os << "EVisibility::Hidden";

break;

- case COLLAPSE:

- *os << "COLLAPSE";

+ case EVisibility::Collapse:

+ *os << "EVisibility::Collapse";

break;

default:

- *os << "Unknown Visbilility - update switch in AnimatableValueTestHelper.h";

+ *os << "Unknown Visibility - update switch in AnimatableValueTestHelper.h";

}

*os << ")";

}