third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp - Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp

Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_move_computedstyle_around

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/style/ComputedStyleConstants.h ('K') | « third_party/WebKit/Source/modules/accessibility/AXObject.cpp ('k') | third_party/WebKit/Source/web/PopupMenuImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp

diff --git a/third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp b/third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp

index adf3a3ef9a027ccabaa15dd76a2806985f2fc2fc..34076a3bded73576ab3523e6fcb6f3e36eb1d2f5 100644

--- a/third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp

+++ b/third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp

@@ -115,7 +115,7 @@ static bool iframeIsAbovePlugin(const Vector<const LayoutObject*>& iframeZstack,

static bool intersectsRect(const LayoutObject* renderer, const IntRect& rect)

{

return renderer->absoluteBoundingBoxRectIgnoringTransforms().intersects(rect)

- && (!renderer->style() || renderer->style()->visibility() == VISIBLE);

+ && (!renderer->style() || renderer->style()->visibility() == EVisibility::Visible);

}

static void addToOcclusions(const LayoutBox* renderer, Vector<IntRect>& occlusions)