Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.h

Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_move_computedstyle_around
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.h
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.h b/third_party/WebKit/Source/core/style/ComputedStyle.h
index fee328e23171e67405ef60f6aeeb23f708d4012b..a66a3f692703a6fc7afc027125741241d2e39597 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.h
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.h
@@ -298,7 +298,7 @@ protected:
m_inheritedData.m_captionSide = initialCaptionSide();
m_inheritedData.m_listStyleType = initialListStyleType();
m_inheritedData.m_listStylePosition = initialListStylePosition();
- m_inheritedData.m_visibility = initialVisibility();
+ m_inheritedData.m_visibility = static_cast<unsigned>(initialVisibility());
m_inheritedData.m_textAlign = initialTextAlign();
m_inheritedData.m_textTransform = initialTextTransform();
m_inheritedData.m_textUnderline = false;
@@ -1468,9 +1468,9 @@ public:
void setTextTransform(ETextTransform v) { m_inheritedData.m_textTransform = v; }
// visibility
- static EVisibility initialVisibility() { return VISIBLE; }
+ static EVisibility initialVisibility() { return EVisibility::Visible; }
EVisibility visibility() const { return static_cast<EVisibility>(m_inheritedData.m_visibility); }
- void setVisibility(EVisibility v) { m_inheritedData.m_visibility = v; }
+ void setVisibility(EVisibility v) { m_inheritedData.m_visibility = static_cast<unsigned>(v); }
// white-space inherited
static EWhiteSpace initialWhiteSpace() { return NORMAL; }

Powered by Google App Engine
This is Rietveld 408576698