Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Unified Diff: third_party/WebKit/Source/core/paint/ObjectPainter.cpp

Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_move_computedstyle_around
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/ObjectPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/ObjectPainter.cpp b/third_party/WebKit/Source/core/paint/ObjectPainter.cpp
index 3e7e094e09d81c58fe332d7bfff26c59066bb6ed..8eb4781985632f646ec8669913ad414ed59003c8 100644
--- a/third_party/WebKit/Source/core/paint/ObjectPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/ObjectPainter.cpp
@@ -206,7 +206,7 @@ void ObjectPainter::paintOutline(const PaintInfo& paintInfo, const LayoutPoint&
ASSERT(shouldPaintSelfOutline(paintInfo.phase));
const ComputedStyle& styleToUse = m_layoutObject.styleRef();
- if (!styleToUse.hasOutline() || styleToUse.visibility() != VISIBLE)
+ if (!styleToUse.hasOutline() || styleToUse.visibility() != EVisibility::Visible)
return;
// Only paint the focus ring by hand if the theme isn't able to draw the focus ring.
@@ -268,7 +268,7 @@ void ObjectPainter::paintInlineChildrenOutlines(const PaintInfo& paintInfo, cons
void ObjectPainter::addPDFURLRectIfNeeded(const PaintInfo& paintInfo, const LayoutPoint& paintOffset)
{
ASSERT(paintInfo.isPrinting());
- if (m_layoutObject.isElementContinuation() || !m_layoutObject.node() || !m_layoutObject.node()->isLink() || m_layoutObject.styleRef().visibility() != VISIBLE)
+ if (m_layoutObject.isElementContinuation() || !m_layoutObject.node() || !m_layoutObject.node()->isLink() || m_layoutObject.styleRef().visibility() != EVisibility::Visible)
return;
KURL url = toElement(m_layoutObject.node())->hrefURL();

Powered by Google App Engine
This is Rietveld 408576698