third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp - Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp

Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_move_computedstyle_around

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.cpp » ('j') | third_party/WebKit/Source/core/style/ComputedStyleConstants.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp

index 262ec0db5ce8f9d9ccc80b48004edd9c6222beb1..2678f0f6459c05bf75998e019a83cd8d43f3b8c7 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp

@@ -86,7 +86,7 @@ bool LayoutSVGResourceClipper::calculateClipContentPathIfNeeded()

continue;

const ComputedStyle* style = childLayoutObject->style();

- if (!style || style->display() == NONE || (style->visibility() != VISIBLE && !isSVGUseElement(*childElement)))

+ if (!style || style->display() == NONE || (style->visibility() != EVisibility::Visible && !isSVGUseElement(*childElement)))

continue;

// Current shape in clip-path gets clipped too. Fallback to masking.

@@ -177,7 +177,7 @@ PassRefPtr<const SkPicture> LayoutSVGResourceClipper::createContentPicture()

continue;

const ComputedStyle* style = layoutObject->style();

- if (!style || style->display() == NONE || (style->visibility() != VISIBLE && !isSVGUseElement(*childElement)))

+ if (!style || style->display() == NONE || (style->visibility() != EVisibility::Visible && !isSVGUseElement(*childElement)))

continue;

bool isUseElement = isSVGUseElement(*childElement);

@@ -221,7 +221,7 @@ void LayoutSVGResourceClipper::calculateLocalClipBounds()

if (!layoutObject->isSVGShape() && !layoutObject->isSVGText() && !isSVGUseElement(*childElement))

continue;

const ComputedStyle* style = layoutObject->style();

- if (!style || style->display() == NONE || (style->visibility() != VISIBLE && !isSVGUseElement(*childElement)))

+ if (!style || style->display() == NONE || (style->visibility() != EVisibility::Visible && !isSVGUseElement(*childElement)))

continue;

if (isSVGUseElement(*childElement) && !toSVGUseElement(*childElement).visibleTargetGraphicsElementForClipping())

continue;