third_party/WebKit/Source/core/html/forms/InputType.cpp - Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/InputType.cpp

Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_move_computedstyle_around

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLAreaElement.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | third_party/WebKit/Source/core/style/ComputedStyleConstants.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/forms/InputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/InputType.cpp b/third_party/WebKit/Source/core/html/forms/InputType.cpp

index 2bb347f17cd0b2a4f70ba71c76e265e0ae260a7b..2ffac571c91546d8d0053ccce2bcd4f0bccecaa4 100644

--- a/third_party/WebKit/Source/core/html/forms/InputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/InputType.cpp

@@ -593,7 +593,7 @@ void InputType::warnIfValueIsInvalidAndElementIsVisible(const String& value) con

{

// Don't warn if the value is set in Modernizr.

const ComputedStyle* style = element().computedStyle();

- if (style && style->visibility() != HIDDEN)

+ if (style && style->visibility() != EVisibility::Hidden)

warnIfValueIsInvalid(value);

}

@@ -911,7 +911,7 @@ void InputType::stepUpFromLayoutObject(int n)

void InputType::countUsageIfVisible(UseCounter::Feature feature) const

{

if (const ComputedStyle* style = element().computedStyle()) {

- if (style->visibility() != HIDDEN)

+ if (style->visibility() != EVisibility::Hidden)

UseCounter::count(element().document(), feature);

}