Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_move_computedstyle_around
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
index 574b331f21d4fadea21b884ff30d4483c6e140e6..dd8e963354bda5ff8036228abca6213577972601 100644
--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
@@ -2509,13 +2509,13 @@ template<> inline CSSPrimitiveValue::CSSPrimitiveValue(EVisibility e)
{
init(UnitType::ValueID);
switch (e) {
- case VISIBLE:
+ case EVisibility::Visible:
m_value.valueID = CSSValueVisible;
break;
- case HIDDEN:
+ case EVisibility::Hidden:
m_value.valueID = CSSValueHidden;
break;
- case COLLAPSE:
+ case EVisibility::Collapse:
m_value.valueID = CSSValueCollapse;
break;
}
@@ -2526,17 +2526,17 @@ template<> inline EVisibility CSSPrimitiveValue::convertTo() const
ASSERT(isValueID());
switch (m_value.valueID) {
case CSSValueHidden:
- return HIDDEN;
+ return EVisibility::Hidden;
case CSSValueVisible:
- return VISIBLE;
+ return EVisibility::Visible;
case CSSValueCollapse:
- return COLLAPSE;
+ return EVisibility::Collapse;
default:
break;
}
ASSERT_NOT_REACHED();
- return VISIBLE;
+ return EVisibility::Visible;
}
template<> inline CSSPrimitiveValue::CSSPrimitiveValue(EWhiteSpace e)

Powered by Google App Engine
This is Rietveld 408576698