third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp - Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp

Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_move_computedstyle_around

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelper.cpp » ('j') | third_party/WebKit/Source/core/style/ComputedStyleConstants.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp

index d0c5772063dd38689bd9bff58f73b40b71123511..caf47737bc4ec1187e9a42f99d5d16673c9d4354 100644

--- a/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp

@@ -32,8 +32,8 @@ public:

return m_start;

if (fraction >= 1)

return m_end;

- if (m_start == VISIBLE || m_end == VISIBLE)

- return VISIBLE;

+ if (m_start == EVisibility::Visible || m_end == EVisibility::Visible)

+ return EVisibility::Visible;

return fraction < 0.5 ? m_start : m_end;

}

@@ -113,7 +113,7 @@ InterpolationValue CSSVisibilityInterpolationType::maybeConvertNeutral(const Int

InterpolationValue CSSVisibilityInterpolationType::maybeConvertInitial(const StyleResolverState&, ConversionCheckers&) const

{

- return createVisibilityValue(VISIBLE);

+ return createVisibilityValue(EVisibility::Visible);

}

InterpolationValue CSSVisibilityInterpolationType::maybeConvertInherit(const StyleResolverState& state, ConversionCheckers& conversionCheckers) const