Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutText.cpp

Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_move_computedstyle_around
Patch Set: Added underlying type notes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * (C) 1999 Lars Knoll (knoll@kde.org) 2 * (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Dirk Mueller (mueller@kde.org) 3 * (C) 2000 Dirk Mueller (mueller@kde.org)
4 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
5 * Copyright (C) 2006 Andrew Wellington (proton@wiretapped.net) 5 * Copyright (C) 2006 Andrew Wellington (proton@wiretapped.net)
6 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com) 6 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 1611 matching lines...) Expand 10 before | Expand all | Expand 10 after
1622 LayoutUnit logicalHeight = lastTextBox()->logicalBottomVisualOverflow() - lo gicalTop; 1622 LayoutUnit logicalHeight = lastTextBox()->logicalBottomVisualOverflow() - lo gicalTop;
1623 1623
1624 LayoutRect rect(logicalLeftSide, logicalTop, logicalWidth, logicalHeight); 1624 LayoutRect rect(logicalLeftSide, logicalTop, logicalWidth, logicalHeight);
1625 if (!style()->isHorizontalWritingMode()) 1625 if (!style()->isHorizontalWritingMode())
1626 rect = rect.transposedRect(); 1626 rect = rect.transposedRect();
1627 return rect; 1627 return rect;
1628 } 1628 }
1629 1629
1630 LayoutRect LayoutText::localOverflowRectForPaintInvalidation() const 1630 LayoutRect LayoutText::localOverflowRectForPaintInvalidation() const
1631 { 1631 {
1632 if (style()->visibility() != VISIBLE) 1632 if (style()->visibility() != EVisibility::Visible)
1633 return LayoutRect(); 1633 return LayoutRect();
1634 1634
1635 return unionRect(visualOverflowRect(), localSelectionRect()); 1635 return unionRect(visualOverflowRect(), localSelectionRect());
1636 } 1636 }
1637 1637
1638 LayoutRect LayoutText::localSelectionRect() const 1638 LayoutRect LayoutText::localSelectionRect() const
1639 { 1639 {
1640 ASSERT(!needsLayout()); 1640 ASSERT(!needsLayout());
1641 1641
1642 if (getSelectionState() == SelectionNone) 1642 if (getSelectionState() == SelectionNone)
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
1753 for (InlineTextBox* box = firstTextBox(); box; box = box->nextTextBox()) { 1753 for (InlineTextBox* box = firstTextBox(); box; box = box->nextTextBox()) {
1754 invalidateDisplayItemClient(*box, invalidationReason); 1754 invalidateDisplayItemClient(*box, invalidationReason);
1755 if (box->truncation() != cNoTruncation) { 1755 if (box->truncation() != cNoTruncation) {
1756 if (EllipsisBox* ellipsisBox = box->root().ellipsisBox()) 1756 if (EllipsisBox* ellipsisBox = box->root().ellipsisBox())
1757 invalidateDisplayItemClient(*ellipsisBox, invalidationReason); 1757 invalidateDisplayItemClient(*ellipsisBox, invalidationReason);
1758 } 1758 }
1759 } 1759 }
1760 } 1760 }
1761 1761
1762 } // namespace blink 1762 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698