Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGUseElement.cpp

Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_move_computedstyle_around
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org> 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org>
3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
4 * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved. 4 * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved.
5 * Copyright (C) 2011 Torch Mobile (Beijing) Co. Ltd. All rights reserved. 5 * Copyright (C) 2011 Torch Mobile (Beijing) Co. Ltd. All rights reserved.
6 * Copyright (C) 2012 University of Szeged 6 * Copyright (C) 2012 University of Szeged
7 * Copyright (C) 2012 Renata Hodovan <reni@webkit.org> 7 * Copyright (C) 2012 Renata Hodovan <reni@webkit.org>
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 501 matching lines...) Expand 10 before | Expand all | Expand 10 after
512 512
513 SVGElement& element = toSVGElement(*n); 513 SVGElement& element = toSVGElement(*n);
514 514
515 if (!element.isSVGGraphicsElement()) 515 if (!element.isSVGGraphicsElement())
516 return nullptr; 516 return nullptr;
517 517
518 if (!element.layoutObject()) 518 if (!element.layoutObject())
519 return nullptr; 519 return nullptr;
520 520
521 const ComputedStyle* style = element.layoutObject()->style(); 521 const ComputedStyle* style = element.layoutObject()->style();
522 if (!style || style->visibility() != VISIBLE) 522 if (!style || style->visibility() != EVisibility::Visible)
523 return nullptr; 523 return nullptr;
524 524
525 // Spec: "If a <use> element is a child of a clipPath element, it must direc tly 525 // Spec: "If a <use> element is a child of a clipPath element, it must direc tly
526 // reference <path>, <text> or basic shapes elements. Indirect references ar e an 526 // reference <path>, <text> or basic shapes elements. Indirect references ar e an
527 // error and the clipPath element must be ignored." 527 // error and the clipPath element must be ignored."
528 // http://dev.w3.org/fxtf/css-masking-1/#the-clip-path 528 // http://dev.w3.org/fxtf/css-masking-1/#the-clip-path
529 if (!isDirectReference(element)) { 529 if (!isDirectReference(element)) {
530 // Spec: Indirect references are an error (14.3.5) 530 // Spec: Indirect references are an error (14.3.5)
531 return nullptr; 531 return nullptr;
532 } 532 }
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
756 756
757 if (m_resource) 757 if (m_resource)
758 m_resource->removeClient(this); 758 m_resource->removeClient(this);
759 759
760 m_resource = resource; 760 m_resource = resource;
761 if (m_resource) 761 if (m_resource)
762 m_resource->addClient(this); 762 m_resource->addClient(this);
763 } 763 }
764 764
765 } // namespace blink 765 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698