Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGUseElement.cpp

Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_move_computedstyle_around
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org> 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org>
3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
4 * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved. 4 * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved.
5 * Copyright (C) 2011 Torch Mobile (Beijing) Co. Ltd. All rights reserved. 5 * Copyright (C) 2011 Torch Mobile (Beijing) Co. Ltd. All rights reserved.
6 * Copyright (C) 2012 University of Szeged 6 * Copyright (C) 2012 University of Szeged
7 * Copyright (C) 2012 Renata Hodovan <reni@webkit.org> 7 * Copyright (C) 2012 Renata Hodovan <reni@webkit.org>
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 497 matching lines...) Expand 10 before | Expand all | Expand 10 after
508 508
509 SVGElement& element = toSVGElement(*n); 509 SVGElement& element = toSVGElement(*n);
510 510
511 if (!element.isSVGGraphicsElement()) 511 if (!element.isSVGGraphicsElement())
512 return nullptr; 512 return nullptr;
513 513
514 if (!element.layoutObject()) 514 if (!element.layoutObject())
515 return nullptr; 515 return nullptr;
516 516
517 const ComputedStyle* style = element.layoutObject()->style(); 517 const ComputedStyle* style = element.layoutObject()->style();
518 if (!style || style->visibility() != VISIBLE) 518 if (!style || style->visibility() != EVisibility::Visible)
519 return nullptr; 519 return nullptr;
520 520
521 // Spec: "If a <use> element is a child of a clipPath element, it must direc tly 521 // Spec: "If a <use> element is a child of a clipPath element, it must direc tly
522 // reference <path>, <text> or basic shapes elements. Indirect references ar e an 522 // reference <path>, <text> or basic shapes elements. Indirect references ar e an
523 // error and the clipPath element must be ignored." 523 // error and the clipPath element must be ignored."
524 // http://dev.w3.org/fxtf/css-masking-1/#the-clip-path 524 // http://dev.w3.org/fxtf/css-masking-1/#the-clip-path
525 if (!isDirectReference(element)) { 525 if (!isDirectReference(element)) {
526 // Spec: Indirect references are an error (14.3.5) 526 // Spec: Indirect references are an error (14.3.5)
527 return nullptr; 527 return nullptr;
528 } 528 }
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
744 744
745 if (m_resource) 745 if (m_resource)
746 m_resource->removeClient(this); 746 m_resource->removeClient(this);
747 747
748 m_resource = resource; 748 m_resource = resource;
749 if (m_resource) 749 if (m_resource)
750 m_resource->addClient(this); 750 m_resource->addClient(this);
751 } 751 }
752 752
753 } // namespace blink 753 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698