Changed ComputedStyle's EVisibility to be an enum class and fixed naming

third_party/WebKit/Source/core/style/ComputedStyleConstants.h

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  *           (C) 2000 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 12 matching lines @@
  *
  */
 
 #ifndef ComputedStyleConstants_h
 #define ComputedStyleConstants_h
 
 #include <cstddef>
 
 namespace blink {
 
+// TODO(sashab): Change these enums to enum classes with an unsigned underlying
+// type. Enum classes provide better type safety, and forcing an unsigned
+// underlying type prevents msvc from interpreting enums as negative numbers.
+// See: crbug.com/628043
+
 // Sides used when drawing borders and outlines. The values should run clockwise from top.
 enum BoxSide {
     BSTop,
     BSRight,
     BSBottom,
     BSLeft
 };
 
 enum StyleRecalcChange {
     NoChange,
@@ skipping 336 matching lines @@
 enum EEmptyCells {
     EmptyCellsShow, EmptyCellsHide
 };
 
 enum ECaptionSide {
     CaptionSideTop, CaptionSideBottom, CaptionSideLeft, CaptionSideRight
 };
 
 enum EListStylePosition { ListStylePositionOutside, ListStylePositionInside };
 
-enum EVisibility { VISIBLE, HIDDEN, COLLAPSE };
+// TODO(sashab): Add a static_assert when this is used in bitfields to ensure it
+// uses unsigned as the underlying type.
+enum class EVisibility : unsigned { Visible, Hidden, Collapse };

[tkent, 2016/08/10 01:11:33]

Can you drop 'E' prefix from enum type names in your project?  It's an ancient
naming convention in kHTML era.
Also, can you add 'k' prefixes to enum item names?

[sashab, 2016/08/10 01:14:51]

Sure, so just to clarify:

enum class Visibility : unsigned { kVisibile, kHidden, kCollapse };

[tkent, 2016/08/10 01:18:43]

Exactly!

 
 enum ECursor {
     // The following must match the order in CSSValueKeywords.in.
     CURSOR_AUTO,
     CURSOR_CROSS,
     CURSOR_DEFAULT,
     CURSOR_POINTER,
     CURSOR_MOVE,
     CURSOR_VERTICAL_TEXT,
     CURSOR_CELL,
@@ skipping 213 matching lines @@
 
 enum AutoRepeatType {
     NoAutoRepeat,
     AutoFill,
     AutoFit
 };
 
 } // namespace blink
 
 #endif // ComputedStyleConstants_h