Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_move_computedstyle_around
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 1131 matching lines...) Expand 10 before | Expand all | Expand 10 after
1142 return createPositionWithAffinity(caretMaxOffset()); 1142 return createPositionWithAffinity(caretMaxOffset());
1143 if (pointLogicalTop < 0) 1143 if (pointLogicalTop < 0)
1144 return createPositionWithAffinity(caretMinOffset()); 1144 return createPositionWithAffinity(caretMinOffset());
1145 if (pointLogicalTop >= logicalHeight()) 1145 if (pointLogicalTop >= logicalHeight())
1146 return createPositionWithAffinity(caretMaxOffset()); 1146 return createPositionWithAffinity(caretMaxOffset());
1147 return PositionWithAffinity(); 1147 return PositionWithAffinity();
1148 } 1148 }
1149 1149
1150 static inline bool isChildHitTestCandidate(LayoutBox* box) 1150 static inline bool isChildHitTestCandidate(LayoutBox* box)
1151 { 1151 {
1152 return box->size().height() && box->style()->visibility() == VISIBLE && !box ->isFloatingOrOutOfFlowPositioned() && !box->isLayoutFlowThread(); 1152 return box->size().height() && box->style()->visibility() == EVisibility::Vi sible && !box->isFloatingOrOutOfFlowPositioned() && !box->isLayoutFlowThread();
1153 } 1153 }
1154 1154
1155 PositionWithAffinity LayoutBlock::positionForPoint(const LayoutPoint& point) 1155 PositionWithAffinity LayoutBlock::positionForPoint(const LayoutPoint& point)
1156 { 1156 {
1157 if (isTable()) 1157 if (isTable())
1158 return LayoutBox::positionForPoint(point); 1158 return LayoutBox::positionForPoint(point);
1159 1159
1160 if (isAtomicInlineLevel()) { 1160 if (isAtomicInlineLevel()) {
1161 PositionWithAffinity position = positionForPointIfOutsideAtomicInlineLev el(point); 1161 PositionWithAffinity position = positionForPointIfOutsideAtomicInlineLev el(point);
1162 if (!position.isNull()) 1162 if (!position.isNull())
(...skipping 704 matching lines...) Expand 10 before | Expand all | Expand 10 after
1867 for (TrackedLayoutBoxListHashSet::const_iterator it = positionedDescenda ntSet->begin(); it != end; ++it) { 1867 for (TrackedLayoutBoxListHashSet::const_iterator it = positionedDescenda ntSet->begin(); it != end; ++it) {
1868 LayoutBox* currBox = *it; 1868 LayoutBox* currBox = *it;
1869 ASSERT(!currBox->needsLayout()); 1869 ASSERT(!currBox->needsLayout());
1870 } 1870 }
1871 } 1871 }
1872 } 1872 }
1873 1873
1874 #endif 1874 #endif
1875 1875
1876 } // namespace blink 1876 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698