Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_move_computedstyle_around
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
8 * (C) 2007 Eric Seidel (eric@webkit.org) 8 * (C) 2007 Eric Seidel (eric@webkit.org)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 return hasRareData() ? elementRareData()->tabIndex() : 0; 233 return hasRareData() ? elementRareData()->tabIndex() : 0;
234 } 234 }
235 235
236 bool Element::layoutObjectIsFocusable() const 236 bool Element::layoutObjectIsFocusable() const
237 { 237 {
238 // Elements in canvas fallback content are not rendered, but they are allowe d to be 238 // Elements in canvas fallback content are not rendered, but they are allowe d to be
239 // focusable as long as their canvas is displayed and visible. 239 // focusable as long as their canvas is displayed and visible.
240 if (isInCanvasSubtree()) { 240 if (isInCanvasSubtree()) {
241 const HTMLCanvasElement* canvas = Traversal<HTMLCanvasElement>::firstAnc estorOrSelf(*this); 241 const HTMLCanvasElement* canvas = Traversal<HTMLCanvasElement>::firstAnc estorOrSelf(*this);
242 DCHECK(canvas); 242 DCHECK(canvas);
243 return canvas->layoutObject() && canvas->layoutObject()->style()->visibi lity() == VISIBLE; 243 return canvas->layoutObject() && canvas->layoutObject()->style()->visibi lity() == EVisibility::Visible;
244 } 244 }
245 245
246 // FIXME: Even if we are not visible, we might have a child that is visible. 246 // FIXME: Even if we are not visible, we might have a child that is visible.
247 // Hyatt wants to fix that some day with a "has visible content" flag or the like. 247 // Hyatt wants to fix that some day with a "has visible content" flag or the like.
248 return layoutObject() && layoutObject()->style()->visibility() == VISIBLE; 248 return layoutObject() && layoutObject()->style()->visibility() == EVisibilit y::Visible;
249 } 249 }
250 250
251 Node* Element::cloneNode(bool deep) 251 Node* Element::cloneNode(bool deep)
252 { 252 {
253 return deep ? cloneElementWithChildren() : cloneElementWithoutChildren(); 253 return deep ? cloneElementWithChildren() : cloneElementWithoutChildren();
254 } 254 }
255 255
256 Element* Element::cloneElementWithChildren() 256 Element* Element::cloneElementWithChildren()
257 { 257 {
258 Element* clone = cloneElementWithoutChildren(); 258 Element* clone = cloneElementWithoutChildren();
(...skipping 3525 matching lines...) Expand 10 before | Expand all | Expand 10 after
3784 3784
3785 DEFINE_TRACE_WRAPPERS(Element) 3785 DEFINE_TRACE_WRAPPERS(Element)
3786 { 3786 {
3787 if (hasRareData()) { 3787 if (hasRareData()) {
3788 visitor->traceWrappers(elementRareData()); 3788 visitor->traceWrappers(elementRareData());
3789 } 3789 }
3790 ContainerNode::traceWrappers(visitor); 3790 ContainerNode::traceWrappers(visitor);
3791 } 3791 }
3792 3792
3793 } // namespace blink 3793 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698