third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp - Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp

Issue 2181953004: Changed ComputedStyle's EVisibility to be an enum class and fixed naming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_move_computedstyle_around

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelper.cpp ('k') | third_party/WebKit/Source/core/animation/animatable/AnimatableVisibility.cpp » ('j') | third_party/WebKit/Source/core/style/ComputedStyleConstants.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2013, Google Inc. All rights reserved.	2 * Copyright (c) 2013, Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 63 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
74 l2->append(Length(2, blink::Percent));	74 l2->append(Length(2, blink::Percent));

75 EXPECT_EQ(	75 EXPECT_EQ(

76 ::std::string("AnimatableStrokeDasharrayList(1+0%, 0+2%)"),	76 ::std::string("AnimatableStrokeDasharrayList(1+0%, 0+2%)"),

77 PrintToString(AnimatableStrokeDasharrayList::create(l2, 1)));	77 PrintToString(AnimatableStrokeDasharrayList::create(l2, 1)));

78	78

79 EXPECT_EQ(	79 EXPECT_EQ(

80 ::std::string("AnimatableUnknown(none)"),	80 ::std::string("AnimatableUnknown(none)"),

81 PrintToString(AnimatableUnknown::create(CSSPrimitiveValue::createIdentif ier(CSSValueNone))));	81 PrintToString(AnimatableUnknown::create(CSSPrimitiveValue::createIdentif ier(CSSValueNone))));

82	82

83 EXPECT_EQ(	83 EXPECT_EQ(

84 ::std::string("AnimatableVisibility(VISIBLE)"),	84 ::std::string("AnimatableVisibility(EVisibility::Visible)"),

85 PrintToString(AnimatableVisibility::create(VISIBLE)));	85 PrintToString(AnimatableVisibility::create(EVisibility::Visible)));

86 }	86 }

87	87

88 } // namespace blink	88 } // namespace blink

OLD	NEW