Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: ui/file_manager/file_manager/foreground/elements/files_quick_view.js

Issue 2181953003: Improved security of Quick View by rendering videos and audios inside webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nit Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/elements/files_quick_view.js
diff --git a/ui/file_manager/file_manager/foreground/elements/files_quick_view.js b/ui/file_manager/file_manager/foreground/elements/files_quick_view.js
index 9094af0acba58be4177f3064904b9a02afc00304..098912da64be8e39d2c6ef66e1e31daf0199b103 100644
--- a/ui/file_manager/file_manager/foreground/elements/files_quick_view.js
+++ b/ui/file_manager/file_manager/foreground/elements/files_quick_view.js
@@ -26,7 +26,7 @@ var FilesQuickView = Polymer({
listeners: {
'iron-overlay-closed': 'clear',
- 'files-safe-img-tap-outside': 'close',
+ 'files-safe-media-tap-outside': 'close',
},
// Clears fields.
@@ -115,6 +115,17 @@ var FilesQuickView = Polymer({
},
/**
+ * @param {string} contentUrl
+ * @param {string} type
+ * @return {string}
+ *
+ * @private
+ */
+ videoUrl_: function(contentUrl, type) {
+ return this.isVideo_(type) ? contentUrl : "";
+ },
+
+ /**
* @param {string} type
* @return {boolean}
*
@@ -125,6 +136,17 @@ var FilesQuickView = Polymer({
},
/**
+ * @param {string} contentUrl
+ * @param {string} type
+ * @return {string}
+ *
+ * @private
+ */
+ audioUrl_: function(contentUrl, type) {
+ return this.isAudio_(type) ? contentUrl : "";
+ },
+
+ /**
* @param {string} type
* @return {boolean}
*

Powered by Google App Engine
This is Rietveld 408576698