Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2181943003: [turbofan] Introduce CheckString simplified operator. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce CheckString simplified operator. Introduce the CheckString during native context specialization when we have string map feedback on a LOAD_IC/STORE_IC. The CheckString operator, just like its CheckNumber pendant, renames the input and assigns a proper type, which we will use soon to lower access operations on Strings, i.e. charCodeAt calls or keyed accesses. R=jarin@chromium.org BUG=v8:4930, v8:5141 Committed: https://crrev.com/3deb71fbad8dd61cd335d5801fe176101d2e5283 Cr-Commit-Position: refs/heads/master@{#38076}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -3 lines) Patch
M src/compiler/effect-control-linearizer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 2 chunks +29 lines, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/redundancy-elimination.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Benedikt Meurer
4 years, 4 months ago (2016-07-27 03:47:33 UTC) #1
Benedikt Meurer
Hey Jaro, Here's a preparation work for optimizing string access. Please take a look. Thanks, ...
4 years, 4 months ago (2016-07-27 04:02:27 UTC) #4
Jarin
lgtm
4 years, 4 months ago (2016-07-27 04:13:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181943003/1
4 years, 4 months ago (2016-07-27 04:14:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 04:15:42 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 04:16:39 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3deb71fbad8dd61cd335d5801fe176101d2e5283
Cr-Commit-Position: refs/heads/master@{#38076}

Powered by Google App Engine
This is Rietveld 408576698