Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 2181943002: Rename ParsedChunk to TokenizedChunk in core/html/parser (Closed)

Created:
4 years, 4 months ago by Charlie Harrison
Modified:
4 years, 4 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ParsedChunk to TokenizedChunk in core/html/parser This patch runs s/ParsedChunk/TokenizedChunk/g s/parsedChunk/tokenizedChunk/g in core/html/parser. ParsedChunk is badly named as it only contains chunks of tokens. BUG= Committed: https://crrev.com/d8c6f2aee855fe5e31ebf6a9aca8e91a0baa9152 Cr-Commit-Position: refs/heads/master@{#407773}

Patch Set 1 #

Messages

Total messages: 17 (9 generated)
Charlie Harrison
PTAL!
4 years, 4 months ago (2016-07-26 04:06:46 UTC) #5
kouhei (in TOK)
lgtm
4 years, 4 months ago (2016-07-26 04:07:50 UTC) #6
Charlie Harrison
In a followup let's rename the BackgroundHTMLParser. LookaheadTokenizer maybe?
4 years, 4 months ago (2016-07-26 04:07:56 UTC) #7
kouhei (in TOK)
On 2016/07/26 04:07:56, csharrison wrote: > In a followup let's rename the BackgroundHTMLParser. LookaheadTokenizer maybe? ...
4 years, 4 months ago (2016-07-26 04:11:32 UTC) #8
Charlie Harrison
On 2016/07/26 04:11:32, kouhei wrote: > On 2016/07/26 04:07:56, csharrison wrote: > > In a ...
4 years, 4 months ago (2016-07-26 11:58:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181943002/1
4 years, 4 months ago (2016-07-26 11:59:16 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 12:03:35 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 12:05:20 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8c6f2aee855fe5e31ebf6a9aca8e91a0baa9152
Cr-Commit-Position: refs/heads/master@{#407773}

Powered by Google App Engine
This is Rietveld 408576698