Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2181893002: Rename consumeClipPath to consumeWebkitClipPath in CSSPropertyParser (Closed)

Created:
4 years, 5 months ago by alancutter (OOO until 2018)
Modified:
4 years, 4 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename consumeClipPath to consumeWebkitClipPath in CSSPropertyParser Reading consumeClipPath() mislead me into thinking clip-path supported <basic-shape> values. This rename makes it clearer that only the prefixed version supports those. Committed: https://crrev.com/224144b57f0bfa4ded10cd1cf6f52ce32b031e63 Cr-Commit-Position: refs/heads/master@{#407716}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
alancutter (OOO until 2018)
4 years, 5 months ago (2016-07-26 00:53:56 UTC) #3
Timothy Loh
On 2016/07/26 00:53:56, alancutter wrote: seems reasonable, lgtm
4 years, 4 months ago (2016-07-26 03:28:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2181893002/1
4 years, 4 months ago (2016-07-26 04:31:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 05:37:54 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 05:41:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/224144b57f0bfa4ded10cd1cf6f52ce32b031e63
Cr-Commit-Position: refs/heads/master@{#407716}

Powered by Google App Engine
This is Rietveld 408576698