Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2181843002:
Flip DrMemory memory.fyi builders to GN. (Closed)
|
Created:
4 years, 5 months ago by Dirk Pranke Modified:
4 years, 4 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFlip DrMemory memory.fyi builders to GN.
R=bruening@chromium.org, brettw@chromium.org
BUG=605318
Committed: https://crrev.com/91224d8c9f54a8a6d9ed8fcffb43fde276ce4afa
Cr-Commit-Position: refs/heads/master@{#407940}
Patch Set 1 #
Messages
Total messages: 20 (13 generated)
Description was changed from ========== Flip DrMemory memory.fyi builders to GN. R=dbruening@chromium.org BUG=605318 ========== to ========== Flip DrMemory memory.fyi builders to GN. R=bruening@chromium.org BUG=605318 ==========
dpranke@chromium.org changed reviewers: + bruening@chromium.org - dbruening@chromium.org
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dpranke@chromium.org
The CQ bit was unchecked by dpranke@chromium.org
Description was changed from ========== Flip DrMemory memory.fyi builders to GN. R=bruening@chromium.org BUG=605318 ========== to ========== Flip DrMemory memory.fyi builders to GN. R=bruening@chromium.org, brettw@chromium.org BUG=605318 ==========
dpranke@chromium.org changed reviewers: + brettw@chromium.org
lgtm
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Flip DrMemory memory.fyi builders to GN. R=bruening@chromium.org, brettw@chromium.org BUG=605318 ========== to ========== Flip DrMemory memory.fyi builders to GN. R=bruening@chromium.org, brettw@chromium.org BUG=605318 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Flip DrMemory memory.fyi builders to GN. R=bruening@chromium.org, brettw@chromium.org BUG=605318 ========== to ========== Flip DrMemory memory.fyi builders to GN. R=bruening@chromium.org, brettw@chromium.org BUG=605318 Committed: https://crrev.com/91224d8c9f54a8a6d9ed8fcffb43fde276ce4afa Cr-Commit-Position: refs/heads/master@{#407940} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/91224d8c9f54a8a6d9ed8fcffb43fde276ce4afa Cr-Commit-Position: refs/heads/master@{#407940}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2187043002/ by dpranke@chromium.org. The reason for reverting is: The builders appear to be all sorts of broken in GN; I don't even know how ninja is running at all, and the errors it is producing don't make any sense.. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
